Skip to content

[v10.x] doc,n-api: update matrix for N-API version 4#27832

Closed
richardlau wants to merge 1 commit intonodejs:v10.x-stagingfrom
richardlau:napi-docs-10
Closed

[v10.x] doc,n-api: update matrix for N-API version 4#27832
richardlau wants to merge 1 commit intonodejs:v10.x-stagingfrom
richardlau:napi-docs-10

Conversation

@richardlau
Copy link
Member

@richardlau richardlau commented May 23, 2019

The N-API version was bumped to 4 for Node.js 10 in
#25633

Refs: #25633

This should land in the release with the above referenced PR.

cc @nodejs/lts @nodejs/n-api

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@richardlau
doc,n-api: update matrix for N-API version 4
805f40f 
The N-API version was bumped to 4 for Node.js 10 in
nodejs#25633

Refs: nodejs#25633
@richardlau richardlau added doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API. v10.x labels May 23, 2019
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 23, 2019

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3603

@richardlau richardlau mentioned this pull request May 23, 2019
Merged
@richardlau
Copy link
Member Author

richardlau commented May 23, 2019

Once this lands in a Node.js 10.x release (i.e. the actual version of Node.js 10 that first supports N-API version 4 is known) a follow up PR needs to add that information to the N-API docs on master.

@mhdawson
Copy link
Member

mhdawson commented May 23, 2019

@richardlau I assume the REPLACEME's are handled as part of the release process right?

@richardlau
Copy link
Member Author

richardlau commented May 23, 2019

@richardlau I assume the REPLACEME's are handled as part of the release process right?

Yes, see https://github.com/nodejs/node/blob/master/doc/releases.md#step-3-update-any-replaceme-and-dep00xx-tags-in-the-docs

mhdawson
mhdawson approved these changes May 24, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BethGriggs
Copy link
Member

BethGriggs commented May 28, 2019

Landed on v10.x-staging.

@BethGriggs BethGriggs closed this May 28, 2019
BethGriggs pushed a commit that referenced this pull request May 28, 2019
@richardlau @BethGriggs
doc,n-api: update matrix for N-API version 4
99e969e 
The N-API version was bumped to 4 for Node.js 10 in
#25633

Refs: #25633

PR-URL: #27832
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codebytere codebytere codebytere approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@richardlau @nodejs-github-bot @mhdawson @BethGriggs @codebytere