[v10.x-backport] n-api: mark thread-safe function as stable by gabrielschulhof · Pull Request #25633 · nodejs/node

gabrielschulhof · 2019-01-22T07:37:24Z

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

nodejs-github-bot · 2019-01-22T07:37:26Z

@gabrielschulhof build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2336/pipeline

mhdawson

LGTM

gabrielschulhof · 2019-01-25T19:26:43Z

CI: https://ci.nodejs.org/job/node-test-pull-request/20325/

gabrielschulhof · 2019-01-25T20:31:28Z

Whoops! New CI: https://ci.nodejs.org/job/node-test-pull-request/20334/

gabrielschulhof · 2019-01-26T06:16:23Z

Resumed as: https://ci.nodejs.org/job/node-test-pull-request/20337/

gabrielschulhof · 2019-01-26T22:20:28Z

Another resume: https://ci.nodejs.org/job/node-test-pull-request/20343/

gabrielschulhof · 2019-01-28T01:33:12Z

...and another resume: https://ci.nodejs.org/job/node-test-pull-request/20367/

gabrielschulhof · 2019-01-28T04:06:46Z

OK, so it looks like we dropped support for FreeBSD 10, but if I am to backport this to to v10.x, I need it to build on FreeBSD 10. Right now it looks like it's failing for an unrelated reason, but I suspect it's part of the reason why we dropped support for FreeBSD 10.

gabrielschulhof · 2019-01-28T04:48:23Z

I ran a job against acf7e7d which is already on v10.x-staging and it also fails the same way: https://ci.nodejs.org/job/node-test-commit-freebsd/23660/

gabrielschulhof · 2019-01-28T18:14:04Z

Now running a job against the commit previous to acf7e7d: https://ci.nodejs.org/job/node-test-commit-freebsd/23677/

gabrielschulhof · 2019-01-29T06:19:27Z

New CI: https://ci.nodejs.org/job/node-test-pull-request/20400/

Fixes: nodejs#24249 PR-URL: nodejs#25556 Backport-PR-URL: nodejs#25633 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

gabrielschulhof · 2019-01-29T19:21:25Z

New CI after rebase: https://ci.nodejs.org/job/node-test-pull-request/20419 (pending as of this writing)

gabrielschulhof · 2019-01-29T21:10:26Z

Resumed as https://ci.nodejs.org/job/node-test-pull-request/20421 (also pending) because the previous one did not seem to run.

gabrielschulhof · 2019-01-29T21:32:38Z

Trying again with https://ci.nodejs.org/job/node-test-pull-request/20424.

gabrielschulhof · 2019-01-30T06:07:45Z

Resumed as: https://ci.nodejs.org/job/node-test-pull-request/20438/ ✔️

Fixes: nodejs#24249 PR-URL: nodejs#25556 Backport-PR-URL: nodejs#25633 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

gabrielschulhof · 2019-03-08T17:23:46Z

New CI: https://ci.nodejs.org/job/node-test-pull-request/21341/

Fixes: #24249 PR-URL: #25556 Backport-PR-URL: #25633 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

BethGriggs · 2019-03-12T22:34:16Z

Landed in 48a5241

The N-API version was bumped to 4 for Node.js 10 in nodejs#25633 Refs: nodejs#25633

The N-API version was bumped to 4 for Node.js 10 in #25633 Refs: #25633

The N-API version was bumped to 4 for Node.js 10 in #25633 Refs: #25633 PR-URL: #27832 Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. node-api Issues and PRs related to the Node-API. v10.x labels Jan 22, 2019

gabrielschulhof force-pushed the un-experimental-tsfn-v10.x branch from fe2664a to 96a21ea Compare January 22, 2019 07:38

mhdawson approved these changes Jan 22, 2019

View reviewed changes

gabrielschulhof added the semver-minor PRs that contain new features and should be released in the next minor version. label Jan 22, 2019

gabrielschulhof force-pushed the un-experimental-tsfn-v10.x branch from 96a21ea to 23a9bda Compare January 25, 2019 19:24

gabrielschulhof force-pushed the un-experimental-tsfn-v10.x branch from 23a9bda to 3a265b0 Compare January 25, 2019 20:30

gabrielschulhof mentioned this pull request Jan 28, 2019

Backports for tsfn nodejs/abi-stable-node#358

Closed

MylesBorins force-pushed the v10.x-staging branch from c1ee936 to c6cffad Compare January 29, 2019 05:06

codebytere force-pushed the v10.x-staging branch from c6cffad to bdab2e9 Compare January 29, 2019 05:57

gabrielschulhof force-pushed the un-experimental-tsfn-v10.x branch from 3a265b0 to 5380f48 Compare January 29, 2019 06:04

gabrielschulhof force-pushed the un-experimental-tsfn-v10.x branch from 5380f48 to 9ced725 Compare January 29, 2019 06:17

codebytere force-pushed the v10.x-staging branch 2 times, most recently from 2d6e145 to 7840f71 Compare January 29, 2019 18:12

n-api: mark thread-safe function as stable

cff27fe

Fixes: nodejs#24249 PR-URL: nodejs#25556 Backport-PR-URL: nodejs#25633 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

gabrielschulhof force-pushed the un-experimental-tsfn-v10.x branch from 9ced725 to cff27fe Compare January 29, 2019 19:19

BethGriggs force-pushed the v10.x-staging branch from 13f9356 to 5711238 Compare February 20, 2019 16:06

gabrielschulhof mentioned this pull request Feb 21, 2019

Missing module in Init nodejs/node-addon-api#449

Closed

rvagg force-pushed the v10.x-staging branch from 5711238 to 156e4c8 Compare February 28, 2019 12:38

BethGriggs approved these changes Mar 12, 2019

View reviewed changes

BethGriggs closed this Mar 12, 2019

richardlau added a commit to richardlau/node-1 that referenced this pull request May 23, 2019

doc,n-api: update matrix for N-API version 4

805f40f

The N-API version was bumped to 4 for Node.js 10 in nodejs#25633 Refs: nodejs#25633

richardlau mentioned this pull request May 23, 2019

[v10.x] doc,n-api: update matrix for N-API version 4 #27832

Closed

3 tasks

BethGriggs pushed a commit that referenced this pull request May 28, 2019

doc,n-api: update matrix for N-API version 4

1ae6853

The N-API version was bumped to 4 for Node.js 10 in #25633 Refs: #25633

gabrielschulhof deleted the un-experimental-tsfn-v10.x branch June 14, 2019 23:51

Uh oh!

Conversation

gabrielschulhof commented Jan 22, 2019

Checklist

Uh oh!

nodejs-github-bot commented Jan 22, 2019

Uh oh!

mhdawson left a comment

Choose a reason for hiding this comment

Uh oh!

gabrielschulhof commented Jan 25, 2019

Uh oh!

gabrielschulhof commented Jan 25, 2019

Uh oh!

gabrielschulhof commented Jan 26, 2019

Uh oh!

gabrielschulhof commented Jan 26, 2019

Uh oh!

gabrielschulhof commented Jan 28, 2019

Uh oh!

gabrielschulhof commented Jan 28, 2019

Uh oh!

gabrielschulhof commented Jan 28, 2019

Uh oh!

gabrielschulhof commented Jan 28, 2019

Uh oh!

gabrielschulhof commented Jan 29, 2019

Uh oh!

gabrielschulhof commented Jan 29, 2019

Uh oh!

gabrielschulhof commented Jan 29, 2019

Uh oh!

gabrielschulhof commented Jan 29, 2019

Uh oh!

gabrielschulhof commented Jan 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gabrielschulhof commented Mar 8, 2019

Uh oh!

BethGriggs commented Mar 12, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

gabrielschulhof commented Jan 30, 2019 •

edited

Loading