module: use validateString in modules/cjs#24863
Closed
ZYSzys wants to merge 1 commit intonodejs:masterfrom
zys-contrib:validator-string
Closed
module: use validateString in modules/cjs#24863ZYSzys wants to merge 1 commit intonodejs:masterfrom zys-contrib:validator-string
ZYSzys wants to merge 1 commit intonodejs:masterfrom
zys-contrib:validator-string
Conversation
richardlau
approved these changes
Dec 6, 2018
2 tasks
BridgeAR
approved these changes
Dec 6, 2018
cjihrig
approved these changes
Dec 6, 2018
lpinca
approved these changes
Dec 6, 2018
trivikr
approved these changes
Dec 8, 2018
Member
trivikr
added
the
author ready
Member
Member
|
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19342/ |
Member
|
Landed in 4dc10ac |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 9, 2018
PR-URL: nodejs#24863 Refs: nodejs#22101 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
PR-URL: nodejs#24863 Refs: nodejs#22101 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simply use
validateStringin modules/cjs.Refs: #22101
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes