lib: extract validateString validator by maclover7 · Pull Request #22101 · nodejs/node

maclover7 · 2018-08-03T04:41:19Z

Pulls out a common argument validator to internal/validators

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

ghost

What about trying to create another new function called "isEmptyString" to check whether your string value is empty:

function isEmptyString (s){
   return (typeof s === 'string' && s.trim() === '');
}

Most of your functions requires a param value that isn't null or empty.
Maybe when both of the things meet, we can continue going on.

maclover7 · 2018-08-03T14:34:26Z

Most of your functions requires a param value that isn't null or empty.

@Maledong Not sure if this is the case -- where do you see this check? I'd rather not add new validations in this PR, since that would be a semver-major change

joyeecheung · 2018-08-03T14:58:02Z

@Maledong Arguably s.trim() === '' is ERR_INVALID_ARG_VALUE and type of s !== 'string' is ERR_INVALID_ARG_TYPE so it may not make sense to mix the validations together. And yeah that'd be semver-major for a couple of APIs.

joyeecheung · 2018-08-03T14:58:54Z

CI: https://ci.nodejs.org/job/node-test-pull-request/16171/

targos · 2018-08-03T15:04:43Z

lib/net.js

-    if (typeof path !== 'string') {
-      throw new ERR_INVALID_ARG_TYPE('options.path', 'string', path);
-    }
+    validateString(path, 'path');


Name changed from "options.path" to "path". I'm on mobile so can't check which one is correct.

Technically both are valid.

I think changing the name was a mistake, but going to put this back to options.path instead of path to make sure this is definitely not semver-major :)

Trott · 2018-08-04T03:44:31Z

CI again: https://ci.nodejs.org/job/node-test-pull-request/16182/

(Didn't use Resume Build because windows-fanned failed and Resume Build does not cooperate with windows-fanned.)

maclover7 · 2018-08-04T21:38:27Z

CI: https://ci.nodejs.org/job/node-test-pull-request/16197/

maclover7 · 2018-08-07T00:26:05Z

updated @targos @lpinca PTAL

lpinca · 2018-08-07T05:11:48Z

Still LGMT.

Pulls out a common argument validator to `internal/validators`

maclover7 · 2018-08-07T15:04:33Z

Landed in e570ae7, thank you for the reviews!

Pulls out a common argument validator to `internal/validators` PR-URL: #22101 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: nodejs#24863 Refs: nodejs#22101 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

PR-URL: nodejs#24960 Refs: nodejs#22101 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

PR-URL: #24863 Refs: #22101 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

PR-URL: #24960 Refs: #22101 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

PR-URL: nodejs#24863 Refs: nodejs#22101 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

PR-URL: nodejs#24960 Refs: nodejs#22101 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

PR-URL: #24863 Refs: #22101 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

Pulls out a common argument validator to `internal/validators` PR-URL: nodejs/node#22101 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

This comment has been minimized.

Sign in to view

nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Aug 3, 2018

ghost reviewed Aug 3, 2018

View reviewed changes

joyeecheung approved these changes Aug 3, 2018

View reviewed changes

targos approved these changes Aug 3, 2018

View reviewed changes

trivikr approved these changes Aug 3, 2018

View reviewed changes

cjihrig approved these changes Aug 3, 2018

View reviewed changes

apapirovski approved these changes Aug 3, 2018

View reviewed changes

lpinca approved these changes Aug 3, 2018

View reviewed changes

jasnell approved these changes Aug 3, 2018

View reviewed changes

targos approved these changes Aug 7, 2018

View reviewed changes

lib: extract validateString validator

fc8d944

Pulls out a common argument validator to `internal/validators`

maclover7 closed this Aug 7, 2018

maclover7 deleted the jm-validatestring branch August 7, 2018 15:04

rvagg mentioned this pull request Aug 13, 2018

Release proposal: v10.9.0 #22295

Merged

ZYSzys mentioned this pull request Dec 6, 2018

module: use validateString in modules/cjs #24863

Closed

2 tasks

ZYSzys mentioned this pull request Dec 11, 2018

lib: refactor argument validation using validateString #24960

Closed

2 tasks

Uh oh!

Conversation

maclover7 commented Aug 3, 2018

Checklist

Uh oh!

This comment has been minimized.

ghost left a comment • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maclover7 commented Aug 3, 2018

Uh oh!

joyeecheung commented Aug 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joyeecheung commented Aug 3, 2018

Uh oh!

targos Aug 3, 2018

Choose a reason for hiding this comment

Uh oh!

lpinca Aug 3, 2018

Choose a reason for hiding this comment

Uh oh!

maclover7 Aug 4, 2018

Choose a reason for hiding this comment

Uh oh!

Trott commented Aug 4, 2018

Uh oh!

maclover7 commented Aug 4, 2018

Uh oh!

maclover7 commented Aug 7, 2018

Uh oh!

lpinca commented Aug 7, 2018

Uh oh!

maclover7 commented Aug 7, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

ghost left a comment •

edited by ghost

Loading

joyeecheung commented Aug 3, 2018 •

edited

Loading