build: make configure script verbose by default#23408
Closed
targos wants to merge 1 commit intonodejs:v10.x-stagingfrom
Closed
build: make configure script verbose by default#23408targos wants to merge 1 commit intonodejs:v10.x-stagingfrom
targos wants to merge 1 commit intonodejs:v10.x-stagingfrom
Conversation
The change that added the --verbose flag was supposed to be semver-major but already landed in a 10.x release. Refs: nodejs#22450
nodejs-github-bot
added
build
Member
Author
|
Please 👍 to fast-track. I'd like to have this in today's release. |
Member
Author
cjihrig
approved these changes
Oct 10, 2018
Trott
approved these changes
Oct 10, 2018
refack
approved these changes
Oct 10, 2018
richardlau
approved these changes
Oct 10, 2018
thefourtheye
approved these changes
Oct 10, 2018
targos
added a commit
that referenced
this pull request
Oct 10, 2018
The change that added the --verbose flag was supposed to be semver-major but already landed in a 10.x release. Refs: #22450 PR-URL: #23408 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Member
Author
|
Landed in c4aa033 |
This was referenced Oct 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change that added the --verbose flag was supposed to be
semver-major but already landed in a 10.x release.
Refs: #22450