build: refactor configure, add `--verbose` by refack · Pull Request #22450 · nodejs/node

refack · 2018-08-21T23:32:15Z

renaming so that IDEs can properly detect this as python
move meta-shebang back to ./configure
add --verbose and patch configure.py to use appropriate output function

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
documentation is changed or added
commit message follows commit guidelines

nodejs-github-bot · 2018-08-21T23:32:16Z

@refack build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/622/pipeline

refack · 2018-08-21T23:33:16Z

/CC @nodejs/build @nodejs/build-files @nodejs/python

Trott · 2018-08-22T04:34:22Z

I would have thought that changing it to configure.py would have broken the Makefile but Travis passed. What sorcery is this?

refack · 2018-08-22T14:58:19Z

What sorcery is this?

In the second commit (258d500) I restore the mega-meta-shebang so that ./configure will still work as before.

refack · 2018-08-22T15:11:31Z

Lite-CI: ~~https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/627/~~

https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/629/pipeline

refack · 2018-08-24T19:37:36Z

Closed by mistake

refack · 2018-08-24T19:37:50Z

@nodejs/build @nodejs/build-files @nodejs/python PTAL

refack · 2018-08-29T17:28:09Z

Could anyone please take a look? up or down...

joyeecheung · 2018-08-30T05:34:20Z

configure

Hmm..can we use another name for the configure.py to avoid confusion? Or maybe a comment here?

richardlau · 2018-08-30T16:08:33Z

We have a makefile dependency on configure:

node/Makefile

Line 132 in 221df22

config.gypi: configure

With the changes in the PR this dependency will be broken? (As in changes are more likely to be in configure.py as opposed to configure which is now merely a wrapper).

refack · 2018-08-30T18:39:54Z

With the changes in the PR this dependency will be broken? (As in changes are more likely to be in configure.py as opposed to configure which is now merely a wrapper).

yeah they both should be dependents...

BridgeAR · 2018-09-05T14:13:14Z

@refack this needs a rebase

refack · 2018-09-05T18:36:33Z

Rebased and running CI: https://ci.nodejs.org/job/node-test-pull-request/17034/

refack · 2018-09-05T22:19:19Z

Resume: https://ci.nodejs.org/job/node-test-commit/21256/

!Should go with next commit! * renaming so that IDEs can properly detect this as python * Add dependency to Makefile PR-URL: nodejs#22450 Reviewed-By: Joyee Cheung <[email protected]>

PR-URL: nodejs#22450 Reviewed-By: Joyee Cheung <[email protected]>

refack · 2018-09-07T14:21:26Z

landed in
d1c5d18
cc9dd0f
62a3f9b

addaleax · 2018-09-07T15:01:35Z

@refack d1c5d18 is a broken commit for bisecting using ./configure && make test – can you squash those together the next time?

refack · 2018-09-07T15:08:34Z

@refack d1c5d18 is a broken commit for bisecting using ./configure && make test – can you squash those together the next time?

Indeed... Sorry.

!Should go with next commit! * renaming so that IDEs can properly detect this as python * Add dependency to Makefile PR-URL: #22450 Reviewed-By: Joyee Cheung <[email protected]>

PR-URL: #22450 Reviewed-By: Joyee Cheung <[email protected]>

richardlau · 2018-10-03T17:48:05Z

Marking semver-major as per #23111 (comment).

The change that added the --verbose flag was supposed to be semver-major but already landed in a 10.x release. Refs: nodejs#22450

The change that added the --verbose flag was supposed to be semver-major but already landed in a 10.x release. Refs: #22450 PR-URL: #23408 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>

!Should go with next commit! * renaming so that IDEs can properly detect this as python * Add dependency to Makefile PR-URL: nodejs#22450 Reviewed-By: Joyee Cheung <[email protected]> (cherry picked from commit d1c5d18)

PR-URL: nodejs#22450 Reviewed-By: Joyee Cheung <[email protected]> (cherry picked from commit cc9dd0f)

nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Aug 21, 2018

refack added the python PRs and issues that require attention from people who are familiar with Python. label Aug 21, 2018

refack force-pushed the tweak-configure-5 branch from 40648fe to a506eb3 Compare August 22, 2018 15:07

refack closed this Aug 23, 2018

refack deleted the tweak-configure-5 branch August 23, 2018 17:20

refack restored the tweak-configure-5 branch August 24, 2018 19:37

refack reopened this Aug 24, 2018

joyeecheung approved these changes Aug 30, 2018

View reviewed changes

configure Outdated

Copy link

Member

joyeecheung Aug 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm..can we use another name for the configure.py to avoid confusion? Or maybe a comment here?

refack force-pushed the tweak-configure-5 branch from ebf34c0 to 6c316a6 Compare September 5, 2018 18:35

refack added 3 commits September 7, 2018 10:17

build: rename configure to configure.py

d1c5d18

!Should go with next commit! * renaming so that IDEs can properly detect this as python * Add dependency to Makefile PR-URL: nodejs#22450 Reviewed-By: Joyee Cheung <[email protected]>

build: move meta-shebang back to configure

cc9dd0f

PR-URL: nodejs#22450 Reviewed-By: Joyee Cheung <[email protected]>

build: add --verbose to ./configure

62a3f9b

PR-URL: nodejs#22450 Reviewed-By: Joyee Cheung <[email protected]>

refack force-pushed the tweak-configure-5 branch from 6c316a6 to 62a3f9b Compare September 7, 2018 14:20

refack merged commit 62a3f9b into nodejs:master Sep 7, 2018

refack deleted the tweak-configure-5 branch September 7, 2018 14:21

targos pushed a commit that referenced this pull request Sep 7, 2018

build: move meta-shebang back to configure

db10db9

PR-URL: #22450 Reviewed-By: Joyee Cheung <[email protected]>

targos pushed a commit that referenced this pull request Sep 7, 2018

build: add --verbose to ./configure

5bae8b9

PR-URL: #22450 Reviewed-By: Joyee Cheung <[email protected]>

addaleax mentioned this pull request Sep 9, 2018

node-report: meld into core #22712

Merged

4 tasks

targos mentioned this pull request Sep 18, 2018

Release proposal: v10.11.0 #22932

Merged

richardlau mentioned this pull request Sep 18, 2018

build: make config verbose on CI #22935

Merged

2 tasks

richardlau mentioned this pull request Sep 27, 2018

configure script in node-v10.11.0.tar.gz source tarball appears truncated #23111

Closed

richardlau added the semver-major PRs that contain breaking changes and should be released in the next major version. label Oct 3, 2018

srl295 mentioned this pull request Oct 3, 2018

tools: ICU shrinker needs to adapt to new output path #23245

Closed

richardlau mentioned this pull request Oct 8, 2018

Release proposal: v10.12.0 #23313

Merged

targos added a commit to targos/node that referenced this pull request Oct 10, 2018

build: make configure script verbose by default

0f0ec4c

The change that added the --verbose flag was supposed to be semver-major but already landed in a 10.x release. Refs: nodejs#22450

targos mentioned this pull request Oct 10, 2018

build: make configure script verbose by default #23408

Closed

anmonteiro mentioned this pull request Oct 20, 2018

configure is now configure.py since Node v10.11 nexe/nexe#538

Closed

BaochengSu pushed a commit to BaochengSu/node that referenced this pull request Oct 20, 2020

build: move meta-shebang back to configure

8423f97

PR-URL: nodejs#22450 Reviewed-By: Joyee Cheung <[email protected]> (cherry picked from commit cc9dd0f)

Uh oh!

Conversation

refack commented Aug 21, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

nodejs-github-bot commented Aug 21, 2018

Uh oh!

refack commented Aug 21, 2018

Uh oh!

Trott commented Aug 22, 2018

Uh oh!

refack commented Aug 22, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

refack commented Aug 22, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

refack commented Aug 24, 2018

Uh oh!

refack commented Aug 24, 2018

Uh oh!

refack commented Aug 29, 2018

Uh oh!

joyeecheung Aug 30, 2018

Choose a reason for hiding this comment

Uh oh!

richardlau commented Aug 30, 2018

Uh oh!

refack commented Aug 30, 2018

Uh oh!

BridgeAR commented Sep 5, 2018

Uh oh!

refack commented Sep 5, 2018

Uh oh!

refack commented Sep 5, 2018

Uh oh!

refack commented Sep 7, 2018

Uh oh!

addaleax commented Sep 7, 2018

Uh oh!

refack commented Sep 7, 2018

Uh oh!

richardlau commented Oct 3, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

refack commented Aug 21, 2018 •

edited

Loading

refack commented Aug 22, 2018 •

edited

Loading

refack commented Aug 22, 2018 •

edited

Loading