clarify that docs must be built before make test#17096
Closed
brettsheffield wants to merge 1 commit intonodejs:masterfrom
brettsheffield:master
Closed
clarify that docs must be built before make test#17096brettsheffield wants to merge 1 commit intonodejs:masterfrom brettsheffield:master
brettsheffield wants to merge 1 commit intonodejs:masterfrom
brettsheffield:master
Conversation
See comment in #16650
Member
|
Sorry, this is not the intended behavior and should be fixed by #16661 .. |
Author
|
Ok. Thanks for clarifying @joyeecheung. If the intention is to fix the behavior, I'll close this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See comment in #16650
Running
make testprior to runningmake docresults in this error:After running
make doc,make testsucceeds.This PR updates BUILDING.md to clarify.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)