tools: try installing js-yaml only once

[joyeecheung]

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

Affected core subsystem(s)

tools

Fixes: #16650

[joyeecheung]

CI: https://ci.nodejs.org/job/node-test-pull-request/11126/

do we have a CI for running make test on a source tarball?

[joyeecheung]

Failures look unrelated

[gibfahn]

do we have a CI for running make test on a source tarball?

No, but we definitely should!

[joyeecheung]

Ping @nodejs/collaborators can someone review this? Thanks!

[richardlau]

Please add install-yaml to the list of phony targets.

[refack]

does doc-targets need to be added as well?

[Trott]

@nodejs/build

[rvagg]

pretty weird, I don't really understand why this makes a difference but if it works @joyeecheung then you can have my lgtm

[joyeecheung]

Added js-yaml to the phony targets per @richardlau 's suggestion. PTAL.

CI: https://ci.nodejs.org/job/node-test-pull-request/11373/

@rvagg

pretty weird, I don't really understand why this makes a difference but if it works @joyeecheung then you can have my lgtm

I am not quite sure either but I can be certain this is related to GNU make, because I can reproduce that bug with gmake but not with make on mac os.

[joyeecheung]

I think I have a rough idea about why this fixes the issue now, it probably has something to do with the gen-doc definition, the bash conditional there is probably interpreted differently in GNU make so moving the conditionals to a separate place somehow works around the compatibility issue. I'll need to dig into that deeper to fix install-yaml properly later, but at least the current patch seem to work.

The pis are not working properly at the moment, this just need a green arm CI before landing.

[joyeecheung]

CI: https://ci.nodejs.org/job/node-test-pull-request/11477/

[joyeecheung]

Smart OS failed, possibly related to #17043 (this time the test/addons/ are missing builds) , still try again to be safe..

New SmartOS CI: https://ci.nodejs.org/job/node-test-commit-smartos/13195/

[joyeecheung]

Landed in f24d961, thanks!