test: fs.write() if 3rd argument is a callback, not offset#17045
Closed
PatrickHeneise wants to merge 3 commits intonodejs:masterfrom
PatrickHeneise:cov-fs-2
Closed
test: fs.write() if 3rd argument is a callback, not offset#17045PatrickHeneise wants to merge 3 commits intonodejs:masterfrom PatrickHeneise:cov-fs-2
PatrickHeneise wants to merge 3 commits intonodejs:masterfrom
PatrickHeneise:cov-fs-2
Conversation
3 tasks
cjihrig
reviewed
Nov 16, 2017
test/parallel/test-fs-write.js
Outdated
| fs.write(fd, expected, 0, 'utf8', done); | ||
| })); | ||
|
|
||
| fs.open(fn, 'w', 0o644, common.mustCall(function(err, fd) { |
Contributor
There was a problem hiding this comment.
I'd use something other than fn to prevent any issues with the tests interacting with one another.
addaleax
approved these changes
Nov 18, 2017
Member
|
CI: https://ci.nodejs.org/job/node-test-commit/14132/ This should be ready. |
addaleax
added
the
author ready
cjihrig
approved these changes
Nov 18, 2017
Member
|
Landed in 8f8999c, thanks for the PR! ✨ |
addaleax
pushed a commit
that referenced
this pull request
Nov 18, 2017
Easier way to resolve conflicts from #16822 and #16827. PR-URL: #17045 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Trott
removed
the
author ready
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
Easier way to resolve conflicts from #16822 and #16827. PR-URL: #17045 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
gibfahn
pushed a commit
that referenced
this pull request
Dec 19, 2017
Easier way to resolve conflicts from #16822 and #16827. PR-URL: #17045 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Closed
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
Easier way to resolve conflicts from #16822 and #16827. PR-URL: #17045 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#16827 and #16822 resulted in some serious merge conflicts, so I decided to open a fresh PR for this with everything resolved.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes