test: fs.write() if 3rd argument is a callback, not offset#16822
Closed
PatrickHeneise wants to merge 4 commits intonodejs:masterfrom
PatrickHeneise:cov-fs
Closed
test: fs.write() if 3rd argument is a callback, not offset#16822PatrickHeneise wants to merge 4 commits intonodejs:masterfrom PatrickHeneise:cov-fs
PatrickHeneise wants to merge 4 commits intonodejs:masterfrom
PatrickHeneise:cov-fs
Conversation
mscdex
reviewed
Nov 6, 2017
test/parallel/test-fs-write.js
Outdated
|
|
||
| fs.open(fn, 'w', 0o644, common.mustCall(function(err, fd) { | ||
| assert.ifError(err); | ||
| console.log('open done'); |
Contributor
There was a problem hiding this comment.
I think these console statements can be left out.
gireeshpunathil
added
code-and-learn
cjihrig
approved these changes
Nov 6, 2017
| fs.open(fn, 'w', 0o644, common.mustCall(function(err, fd) { | ||
| assert.ifError(err); | ||
| const done = common.mustCall(function(err, written) { | ||
| assert.strictEqual(Buffer.byteLength(expected), written); |
Contributor
There was a problem hiding this comment.
Maybe add an assert.ifError(err); here.
jasnell
approved these changes
Nov 8, 2017
3 tasks
Author
|
New PR without conflicts #17045 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes