v8.9.1 proposal by gibfahn · Pull Request #16783 · nodejs/node

gibfahn · 2017-11-05T20:55:40Z

2017-11-07, Version 8.9.1 'Carbon' (LTS), @gibfahn

Notable Changes

openssl:
- upgrade openssl sources to 1.0.2m (Shigeki Ohtsu) Upgrade to OpenSSL-1.0.2m #16691
Revert "https:
- refactor to use http internals" (Myles Borins) #16660

Commits

[6a7e5ceaa9] - deps: V8: cherry-pick 32141e9 from upstream (Ali Ijaz Sheikh) #16704
[a815e1b6a2] - deps: cherry-pick e7f4e9e from upstream libuv (Bartosz Sosnowski) #16724
[7f86e8190c] - deps: update openssl asm and asm_obsolete files (Shigeki Ohtsu) #16691
[1af2244020] - deps: add -no_rand_screen to openssl s_client (Shigeki Ohtsu) nodejs/io.js#1836
[9d98dcc395] - deps: fix asm build error of openssl in x86_win32 (Shigeki Ohtsu) iojs/io.js#1389
[99319efc45] - deps: fix openssl assembly error on ia32 win32 (Fedor Indutny) iojs/io.js#1389
[151a8da4b7] - deps: copy all openssl header files to include dir (Shigeki Ohtsu) #16691
[d68e53452c] - deps: upgrade openssl sources to 1.0.2m (Shigeki Ohtsu) #16691
[a3be5bc560] - doc: add 9.x to version picker and mark 8.x as LTS (Chris Young) #16672
[08b75c1591] - Revert "https: refactor to use http internals" (Myles Borins) #16660
[d334a95834] - openssl: fix keypress requirement in apps on win32 (Shigeki Ohtsu) iojs/io.js#1389
[bf26b96fd6] - src: add 'dynamic' process.release.lts property (Rod Vagg) #16656
[dfac6cc0bb] - test: update process-release for Node 8 Carbon (Jeremiah Senkpiel) #16656

This makes the process.release.lts property configurable by a constant. This ref is the original PR to v6.x. Refs: #3212 Conflicts: doc/api/process.md PR-URL: #16656 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

PR-URL: #16656 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

This replaces all sources of openssl-1.0.2m.tar.gz into deps/openssl/openssl PR-URL: #16691 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>

All symlink files in `deps/openssl/openssl/include/openssl/` are removed and replaced with real header files to avoid issues on Windows. Two files of opensslconf.h in crypto and include dir are replaced to refer config/opensslconf.h. PR-URL: #16691 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>

`x86masm.pl` was mistakenly using .486 instruction set, why `cpuid` (and perhaps others) are requiring .686 . Fixes: #589 PR-URL: #1389 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>

See https://mta.openssl.org/pipermail/openssl-dev/2015-February/000651.html iojs needs to stop using masm and move to nasm or yasm on Win32. Fixes: #589 PR-URL: #1389 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

Reapply b910613 . Fixes: #589 PR-URL: #1389 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

In openssl s_client on Windows, RAND_screen() is invoked to initialize random state but it takes several seconds in each connection. This added -no_rand_screen to openssl s_client on Windows to skip RAND_screen() and gets a better performance in the unit test of test-tls-server-verify. Do not enable this except to use in the unit test. Fixes: #1461 PR-URL: #1836 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

Regenerate asm files with Makefile and CC=gcc and ASM=nasm where gcc version was 5.4.0 and nasm version was 2.11.08. Also asm files in asm_obsolete dir to support old compiler and assembler are regenerated without CC and ASM envs. PR-URL: #16691 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>

This reverts commit 5118f31. It is breaking code in the wild that depends on the original behavior to do tracing. I don't think we need to necessarily fix this in 8.x but we might want to reclassify the original commit as Semver Major PR-URL: #16660 Refs: #16395 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Bryan English <bryan@bryanenglish.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Jan Krems <jan.krems@gmail.com>

PR-URL: #16672 Fixes: https://github.com/node/issues/16671 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Original commit message: tty, win: get SetWinEventHook pointer at startup SetWinEventHook is not available on some Windows versions. Fixes: #16603 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> PR-URL: #16724 Fixes: #16603 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

PR-URL: #16783

gibfahn · 2017-11-05T21:06:02Z

CI: https://ci.nodejs.org/job/node-test-pull-request/11202/
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1061/
rc.1: https://nodejs.org/download/rc/v8.9.1-rc.1 (https://ci-release.nodejs.org/job/iojs+release/2211/)

richardlau · 2017-11-06T03:43:37Z

Shouldn't the openssl notable change be the update to 1.0.2m?

MylesBorins · 2017-11-06T04:02:55Z

+1 to the updated notable change for openssl... the keypress fix is a refloat afaik

MylesBorins · 2017-11-06T04:04:26Z

might want to bring in 3a977fc to fix the flake on windows

Kicking off CI one more time: https://ci.nodejs.org/job/node-test-pull-request/11203/

gibfahn · 2017-11-06T07:52:22Z

Shouldn't the openssl notable change be the update to 1.0.2m?

Hah, yes, copy&paste error.

EDIT: Fixed

PR-URL: #16783

Original commit message: Disable --turbo-inline-array-builtins by default. Current chrome stable has a high number of crashes due to bugs in this feature. These bugs are already fixed but the fixes are hard to merge back. Therefore we decided to disable the feature in stable. This CL is intended to be merged to stable and then reverted in tot. Bug: chromium:762020 Change-Id: Ibd5a08e3b303a204fb84a408271a1c0f97cc5b7b Reviewed-on: https://chromium-review.googlesource.com/738176 Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#48931} Refs: v8/v8@32141e9 PR-URL: #16704

PR-URL: #16783

gibfahn · 2017-11-07T17:35:08Z

CI: https://ci.nodejs.org/job/node-test-pull-request/11273/
CI 2: https://ci.nodejs.org/job/node-test-pull-request/11281/
CitGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1066/

Release: https://ci-release.nodejs.org/job/iojs+release/2222/

Test Failures:

parallel/test-http2-server-rst-stream on smartos16

Test output

not ok 950 parallel/test-http2-server-rst-stream
  ---
  duration_ms: 0.829
  severity: fail
  stack: |-
    (node:31144) ExperimentalWarning: The http2 module is an experimental API.
    assert.js:42
      throw new errors.AssertionError({
      ^
    
    AssertionError [ERR_ASSERTION]: rstWithInternalError is not match rstCode
        at ClientHttp2Stream.req.on.common.mustCall (/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos16-64/test/parallel/test-http2-server-rst-stream.js:55:14)
        at ClientHttp2Stream.<anonymous> (/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos16-64/test/common/index.js:533:15)
        at emitOne (events.js:121:20)
        at ClientHttp2Stream.emit (events.js:211:7)
        at emit (internal/http2/core.js:140:8)
        at _combinedTickCallback (internal/process/next_tick.js:141:11)
        at process._tickCallback (internal/process/next_tick.js:180:9)
  ...

CitGM Failures:

Sodium Native v2.0.0 - didn't fail in previous release (sodium-native@1.10.3)
citgm.ava-v0.23.0 (also failing in 6.12.0)
citgm.coffeescript-v2.0.2 citgm.esprima-v4.0.0 citgm.lodash-v4.17.4 citgm.sax-v1.2.4 citgm.semver-v5.4.1 citgm.thread-sleep-v2.0.0 citgm.watchify-v3.9.0 all failing on AIX or Windows with permissions errors.

Notable Changes: - **openssl**: - upgrade openssl sources to 1.0.2m (Shigeki Ohtsu) [#16691](#16691) - ***Revert*** "**https**: - refactor to use http internals" (Myles Borins) [#16660](#16660) PR-URL: #16783

PR-URL: #16783

Notable Changes: - **openssl**: - upgrade openssl sources to 1.0.2m (Shigeki Ohtsu) [#16691](#16691) - ***Revert*** "**https**: - refactor to use http internals" (Myles Borins) [#16660](#16660) PR-URL: #16783

rvagg and others added 12 commits November 2, 2017 09:28

test: update process-release for Node 8 Carbon

dfac6cc

PR-URL: #16656 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>

openssl: fix keypress requirement in apps on win32

d334a95

Reapply b910613 . Fixes: #589 PR-URL: #1389 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

nodejs-github-bot added meta Issues and PRs related to the general management of the project. openssl Issues and PRs related to the OpenSSL dependency. v8.x labels Nov 5, 2017

gibfahn force-pushed the v8.9.1-proposal branch from b3f68c5 to 3cd916b Compare November 5, 2017 20:59

gibfahn added a commit that referenced this pull request Nov 5, 2017

2017-11-07 Node.js v8.9.1 'Carbon' (LTS) Release

3cd916b

PR-URL: #16783

MylesBorins mentioned this pull request Nov 5, 2017

November 7th release for all lines nodejs/Release#282

Closed

gibfahn mentioned this pull request Nov 5, 2017

console: avoid adding infinite error listeners #16770

Closed

4 tasks

gibfahn force-pushed the v8.9.1-proposal branch from 3cd916b to db430ff Compare November 6, 2017 16:58

gibfahn added a commit that referenced this pull request Nov 6, 2017

2017-11-07 Node.js v8.9.1 'Carbon' (LTS) Release

db430ff

PR-URL: #16783

gibfahn force-pushed the v8.9.1-proposal branch from db430ff to df3c645 Compare November 7, 2017 17:30

gibfahn added a commit that referenced this pull request Nov 7, 2017

2017-11-07 Node.js v8.9.1 'Carbon' (LTS) Release

df3c645

PR-URL: #16783

gibfahn force-pushed the v8.9.1-proposal branch from df3c645 to c25f802 Compare November 7, 2017 20:36

gibfahn force-pushed the v8.9.1-proposal branch from c25f802 to 950d291 Compare November 7, 2017 20:38

2017-11-07, Version 8.9.1 'Carbon' (LTS)

48813de

Notable Changes: - **openssl**: - upgrade openssl sources to 1.0.2m (Shigeki Ohtsu) [#16691](#16691) - ***Revert*** "**https**: - refactor to use http internals" (Myles Borins) [#16660](#16660) PR-URL: #16783

gibfahn force-pushed the v8.9.1-proposal branch from 950d291 to 48813de Compare November 7, 2017 20:52

Working on v8.9.2

edb03cb

PR-URL: #16783

gibfahn merged commit edb03cb into v8.x Nov 7, 2017

gibfahn deleted the v8.9.1-proposal branch November 7, 2017 22:49

gibfahn mentioned this pull request Nov 21, 2017

v8.9.2 proposal #17204

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

v8.9.1 proposal#16783

v8.9.1 proposal#16783
gibfahn merged 15 commits intov8.xfrom
v8.9.1-proposal

gibfahn commented Nov 5, 2017 •

edited

Loading

Uh oh!

gibfahn commented Nov 5, 2017 •

edited

Loading

Uh oh!

richardlau commented Nov 6, 2017

Uh oh!

MylesBorins commented Nov 6, 2017

Uh oh!

MylesBorins commented Nov 6, 2017 •

edited

Loading

Uh oh!

gibfahn commented Nov 6, 2017 •

edited

Loading

Uh oh!

gibfahn commented Nov 7, 2017 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Uh oh!

Conversation

gibfahn commented Nov 5, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

2017-11-07, Version 8.9.1 'Carbon' (LTS), @gibfahn

Notable Changes

Commits

Uh oh!

gibfahn commented Nov 5, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

richardlau commented Nov 6, 2017

Uh oh!

MylesBorins commented Nov 6, 2017

Uh oh!

MylesBorins commented Nov 6, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gibfahn commented Nov 6, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gibfahn commented Nov 7, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Failures:

CitGM Failures:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

gibfahn commented Nov 5, 2017 •

edited

Loading

gibfahn commented Nov 5, 2017 •

edited

Loading

MylesBorins commented Nov 6, 2017 •

edited

Loading

gibfahn commented Nov 6, 2017 •

edited

Loading

gibfahn commented Nov 7, 2017 •

edited

Loading