src: process release lts property#16656
Merged
Fishrock123 merged 2 commits intonodejs:masterfrom Nov 2, 2017
Merged
Conversation
Fishrock123
added
lib / src
nodejs-github-bot
added
the
c++
Contributor
Author
|
|
MylesBorins
approved these changes
Oct 31, 2017
Contributor
MylesBorins
left a comment
MylesBorins
left a comment
There was a problem hiding this comment.
LGTM
Were we going to include updates to node_version.h to make sure the LTS related flags are in there?
doc/api/process.md
Outdated
Contributor
There was a problem hiding this comment.
is there an indent change here or is just github rendering weirdly?
cjihrig
approved these changes
Nov 1, 2017
gireeshpunathil
approved these changes
Nov 1, 2017
Fishrock123
force-pushed
the
process-release-lts-property
branch
from
a84754a to
a808d96
Compare
Fishrock123
force-pushed
the
process-release-lts-property
branch
from
a808d96 to
10fbcef
Compare
apapirovski
approved these changes
Nov 1, 2017
Fishrock123
force-pushed
the
process-release-lts-property
branch
from
10fbcef to
7f73d81
Compare
This makes the process.release.lts property configurable by a constant. This ref is the original PR to v6.x. Refs: nodejs#3212 Conflicts: doc/api/process.md PR-URL: nodejs#16656 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
PR-URL: nodejs#16656 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Fishrock123
force-pushed
the
process-release-lts-property
branch
from
7f73d81 to
d4471e0
Compare
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
Nov 2, 2017
This makes the process.release.lts property configurable by a constant. This ref is the original PR to v6.x. Refs: nodejs#3212 Conflicts: doc/api/process.md PR-URL: nodejs#16656 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Fishrock123
added a commit
to Fishrock123/node
that referenced
this pull request
Nov 2, 2017
PR-URL: nodejs#16656 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Contributor
Author
Merged
cjihrig
pushed a commit
to cjihrig/node
that referenced
this pull request
Nov 6, 2017
This makes the process.release.lts property configurable by a constant. This ref is the original PR to v6.x. Refs: nodejs#3212 Conflicts: doc/api/process.md PR-URL: nodejs#16656 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
cjihrig
pushed a commit
to cjihrig/node
that referenced
this pull request
Nov 6, 2017
PR-URL: nodejs#16656 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a forward-port of 455272a. It is required for LTS release branches to have the correct in-process information when configured with
NODE_VERSION_IS_LTSandNODE_VERSION_LTS_CODENAME. It has no impact otherwise, other than a test which already covers up multiple possible name paths.This should be backported to 8.x asap as it is missing there and as such
process.release.ltsisundefinedin 8.9.0. Myself and @MylesBorins are hoping to get this into the security release later this week (from irc).This lands cleanly on 8.x.
cc also @nodejs/release
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test, src, lts
CI: https://ci.nodejs.org/job/node-test-pull-request/11121/