(v6.x backport) build: don't create directory for NDK toolchain#12975
Closed
diastremskii wants to merge 1 commit intonodejs:v6.x-stagingfrom
Closed
(v6.x backport) build: don't create directory for NDK toolchain#12975diastremskii wants to merge 1 commit intonodejs:v6.x-stagingfrom
diastremskii wants to merge 1 commit intonodejs:v6.x-stagingfrom
Conversation
Let make-standalone-toolchain.sh create directory. PR-URL: nodejs#11916 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
Contributor
|
landed in b179b26 |
andrew749
pushed a commit
to michielbaird/node
that referenced
this pull request
Jul 19, 2017
Let make-standalone-toolchain.sh create directory. PR-URL: nodejs/node#11916 Backport-PR-URL: nodejs/node#12975 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting from commit 90561a... in NDK make-standalone-toolchain.sh requires
--forceoption to write toolchain into existing directory and will fail withRefusing to clobber existing install directoryotherwise.But with
--forceoption script will fail on older versions of NDK. So best option should be just let make-standalone-toolchain.sh create directory.PR-URL: #11916
Reviewed-By: Ben Noordhuis info@bnoordhuis.nl
Reviewed-By: James M Snell jasnell@gmail.com
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
build