Skip to content

build: don't create a new directory for android toolchain#11916

Closed
diastremskii wants to merge 1 commit intonodejs:masterfrom
diastremskii:master
Closed

build: don't create a new directory for android toolchain#11916
diastremskii wants to merge 1 commit intonodejs:masterfrom
diastremskii:master

Conversation

@diastremskii
Copy link
Contributor

@diastremskii diastremskii commented Mar 18, 2017 •
edited
Loading

Starting from commit 90561a... in NDK make-standalone-toolchain.sh requires --force option to write toolchain into existing directory and will fail with Refusing to clobber existing install directory otherwise.
But with --force option script will fail on older versions of NDK. So best option should be just let make-standalone-toolchain.sh create directory.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build

@hiroppy hiroppy added the build Issues and PRs related to build files or the CI. label Mar 18, 2017
@bnoordhuis
Copy link
Member

bnoordhuis commented Mar 20, 2017

@robertchiras You care about the android build, don't you? Can you review?

@aqrln
Copy link
Contributor

aqrln commented Mar 20, 2017

I don't know whether it is critical, but the commit message exceeds 50 characters.

@robertchiras
Copy link
Contributor

robertchiras commented Mar 21, 2017

Indeed, doesn't seem critical, but the change looks good to me.
If the commit message is fixed, this can go in.

bnoordhuis
bnoordhuis requested changes Mar 21, 2017
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments. Can you format the commit log according to the style guide?

@robertchiras Thanks for reviewing.

android-configure Outdated
Copy link
Member

@bnoordhuis bnoordhuis Mar 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you wrap this line at 80 columns?

android-configure Outdated
Copy link
Member

@bnoordhuis bnoordhuis Mar 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rm -rf makes me nervous. Can you at least wrap it in double quotes so spaces in the path don't cause bad behavior?

@diastremskii
Copy link
Contributor Author

diastremskii commented Mar 21, 2017

Oh, sorry. Fixed.

@diastremskii
build: don't create directory for NDK toolchain
fde29f6 
Let make-standalone-toolchain.sh create directory.
@jasnell
Copy link
Member

jasnell commented Mar 22, 2017

FYI: We currently have no way to run this through CI.

jasnell pushed a commit that referenced this pull request Mar 22, 2017
@diastremskii @jasnell
build: don't create directory for NDK toolchain
757c90e 
Let make-standalone-toolchain.sh create directory.

PR-URL: #11916
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Mar 22, 2017

Landed in 757c90e

@jasnell jasnell closed this Mar 22, 2017
MylesBorins pushed a commit that referenced this pull request Mar 28, 2017
@diastremskii @MylesBorins
build: don't create directory for NDK toolchain
3e4ecca 
Let make-standalone-toolchain.sh create directory.

PR-URL: #11916
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 28, 2017
Merged
@italoacasas italoacasas mentioned this pull request Apr 10, 2017
Merged
2 tasks
@MylesBorins
Copy link
Contributor

MylesBorins commented Apr 18, 2017

backport?

@MylesBorins
Copy link
Contributor

MylesBorins commented May 8, 2017

ping

@diastremskii
Copy link
Contributor Author

diastremskii commented May 8, 2017

@MylesBorins, sorry, not sure, should I also make PR into other branch for backport? :)

@gibfahn
Copy link
Member

gibfahn commented May 10, 2017

@TheBeastOfCaerbannog the backport process is covered here, if you could backport to v6.x-staging that'd be ideal.

diastremskii added a commit to diastremskii/node that referenced this pull request May 11, 2017
@diastremskii
build: don't create directory for NDK toolchain
7bf2253 
Let make-standalone-toolchain.sh create directory.

PR-URL: nodejs#11916
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
@diastremskii diastremskii mentioned this pull request May 11, 2017
Closed
2 tasks
MylesBorins pushed a commit that referenced this pull request May 16, 2017
@diastremskii @MylesBorins
build: don't create directory for NDK toolchain
b179b26 
Let make-standalone-toolchain.sh create directory.

PR-URL: #11916
Backport-PR-URL: #12975
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 18, 2017
@diastremskii @MylesBorins
build: don't create directory for NDK toolchain
a0973c3 
Let make-standalone-toolchain.sh create directory.

PR-URL: #11916
Backport-PR-URL: #12975
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request May 23, 2017
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@diastremskii @andrew749
build: don't create directory for NDK toolchain
835aad8 
Let make-standalone-toolchain.sh create directory.

PR-URL: nodejs/node#11916
Backport-PR-URL: nodejs/node#12975
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@jasnell jasnell jasnell approved these changes

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@diastremskii @bnoordhuis @aqrln @robertchiras @jasnell @MylesBorins @gibfahn @hiroppy