fix(OCP): Add since tag to all constants#43595
Merged
nickvergessen merged 1 commit intomasterfrom Feb 15, 2024
Merged
Conversation
SystemKeeper
approved these changes
Feb 15, 2024
Member
|
I don't see a problem exposing them, but seems a bit weird that private visibility still requires a since annotation 🤷 |
juliusknorr
approved these changes
Feb 15, 2024
Member
Author
Same is the case for "private" methods that you could add atm. |
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
bugfix/noid/make-psalm-green-again
branch
from
2a0267d to
3b0a9e6
Compare
4 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Red CI due to parallel merges of
PS: I find private constants weird on public API. Any problem with exposing them? Would allowing apps to create their own providers on top of it.