feat: Migrate LinkReferenceProvider to OCP#43355
Merged
Conversation
Contributor
Author
|
It could've been an abstract class in OCP but that would interfere with |
kyteinsky
force-pushed
the
feat/ocp-link-reference-provider
branch
3 times, most recently
from
a3a84cb to
eee7c0e
Compare
kyteinsky
force-pushed
the
feat/ocp-link-reference-provider
branch
2 times, most recently
from
c6629c8 to
4996970
Compare
julien-nc
approved these changes
Feb 14, 2024
juliusknorr
approved these changes
Feb 14, 2024
Member
|
Contributor
Author
|
there are a lot of changed hashes in the apps. Should that be included in the commit? apps/admin_audit/composer/composer/installed.php
- 'reference' => 'b1797842784b250fb01ed5e3bf130705eb94751b',
+ 'reference' => '49969705de01aff43cf2e6b662e5c96bd48a3b27', |
Member
|
Just the ones updating the class paths should be enough I think |
This would be useful to eleminate the need for using this OC class when an app dev wants to implement a custom reference provider for the web client but wants to fall back on opengraph for mobile clients. Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
kyteinsky
force-pushed
the
feat/ocp-link-reference-provider
branch
from
4996970 to
7329b83
Compare
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This would be useful to eleminate the need for using this OC class
when an app dev wants to implement a custom reference provider
for the web client but wants to fall back on opengraph for mobile
clients.
Checklist