Skip to content

FilePicker: Hide newButton outline if only picking is allowed#33297

Merged
PVince81 merged 1 commit intomasterfrom
fix/filepicker-new-button
Jul 21, 2022
Merged

FilePicker: Hide newButton outline if only picking is allowed#33297
PVince81 merged 1 commit intomasterfrom
fix/filepicker-new-button

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Jul 20, 2022

If the filepicker mode is set to FILEPICKER_TYPE_CHOOSE
currently only the button but not the outline of it is hidden.

This changes the behavior to also hide the outline.

@susnux susnux added bug design Design, UI, UX, etc. 3. to review Waiting for reviews feature: filepicker labels Jul 20, 2022
@susnux
Copy link
Contributor Author

susnux commented Jul 20, 2022

/compile

@susnux
Copy link
Contributor Author

susnux commented Jul 20, 2022

@Pytal Sorry for request the review again. I superseded the previous (already reviewed by you) PR #33249 so that the compile command works.

@susnux susnux mentioned this pull request Jul 20, 2022
Closed
@szaimen
Copy link
Contributor

szaimen commented Jul 20, 2022

/compile amend /

szaimen
szaimen approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
lgtm but did not test

@susnux @nextcloud-command
FilePicker: Hide also outline of new button if type is CHOOSE
003c76c 
If the filepicker mode is set to `FILEPICKER_TYPE_CHOOSE`
currently only the button but not the outline of it is hidden.

This also hides the outline to fix #33142

Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command force-pushed the fix/filepicker-new-button branch from 0bed4ed to 003c76c Compare July 20, 2022 18:03
@github-actions
Copy link
Contributor

github-actions bot commented Jul 20, 2022

Possible performance regression detected

Show Output 
2 queries added

= /remote.php/dav/files/test
= /remote.php/dav/files/test/test.txt
≠ /remote.php/dav/files/test/many_files with 1 queries added
  + UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
= /remote.php/dav/files/test/new_file.txt
≠ /remote.php/dav/files/test/new_file.txt with 1 queries added
  + UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)

@szaimen szaimen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 20, 2022
@PVince81 PVince81 merged commit 6c42874 into master Jul 21, 2022
@PVince81 PVince81 deleted the fix/filepicker-new-button branch July 21, 2022 13:56
@szaimen szaimen mentioned this pull request Jul 21, 2022
Closed
@skjnldsv skjnldsv mentioned this pull request Aug 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pytal Pytal Pytal approved these changes

@szaimen szaimen szaimen approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@artonge artonge Awaiting requested review from artonge

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish bug design Design, UI, UX, etc. feature: filepicker

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Filepicker - Outline of "new" button is not hidden

4 participants

@susnux @szaimen @Pytal @PVince81