FilePicker: Hide newButton outline if only picking is allowed#33249
Closed
susnux wants to merge 1 commit intonextcloud:masterfrom
susnux:fix/filepicker-new-button
Closed
FilePicker: Hide newButton outline if only picking is allowed#33249susnux wants to merge 1 commit intonextcloud:masterfrom susnux:fix/filepicker-new-button
newButton outline if only picking is allowed#33249susnux wants to merge 1 commit intonextcloud:masterfrom
susnux:fix/filepicker-new-button
Conversation
szaimen
added
bug
design
szaimen
requested review from
a team,
CarlSchwan,
PVince81,
artonge and
skjnldsv
and removed request for
a team
Contributor
|
/compile amend / |
Pytal
approved these changes
Jul 18, 2022
If the filepicker mode is set to `FILEPICKER_TYPE_CHOOSE` currently only the button but not the outline of it is hidden. This also hides the outline to fix #33142 Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
Contributor
Author
Closed in favor of #33297 so that the commands work (and the node check succeeds) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the filepicker mode is set to
FILEPICKER_TYPE_CHOOSEcurrently only the button but not the outline of it is hidden.
This changes the behavior to also hide the outline.