Skip to content

Inhibited wrong occurrence of ad-hoc encoding of 64bit doubles on iOS - #270

Merged
redboltz merged 1 commit into
msgpack:masterfrom
makeroo:master
Apr 20, 2015
Merged

Inhibited wrong occurrence of ad-hoc encoding of 64bit doubles on iOS#270
redboltz merged 1 commit into
msgpack:masterfrom
makeroo:master

Conversation

@makeroo

@makeroo makeroo commented Apr 16, 2015

Copy link
Copy Markdown

No description provided.

@redboltz

Copy link
Copy Markdown
Contributor

@makeroo, thank you for sending the PR.
Let me clarify the situation.

  • arm is defined and ARM_EABI is NOT defined on iOS.
  • However, iOS is NOT an oabi.
  • Hence, mem.i = (mem.i & 0xFFFFFFFFUL) << 32UL | (mem.i >> 32UL); is bad for iOS.
  • To distinguish iOS, we can use TARGET_OS_IPHONE.

Is that correct? if it is, I will merge the PR soon.

@makeroo

makeroo commented Apr 20, 2015

Copy link
Copy Markdown
Author

On Mon, Apr 20, 2015 at 7:44 AM, Takatoshi Kondo notifications@github.com
wrote:

@makeroo https://github.com/makeroo, thank you for sending the PR.
Let me clarify the situation.

  • arm is defined and ARM_EABI is NOT defined on iOS.

correct

  • However, iOS is NOT an oabi.

    I'm not sure but I think so

    • Hence, mem.i = (mem.i & 0xFFFFFFFFUL) << 32UL | (mem.i >> 32UL); is
      bad for iOS.

correct

  • To distinguish iOS, we can use TARGET_OS_IPHONE.

correct

Is that correct? if it is, I will merge the PR soon.

thanks


Reply to this email directly or view it on GitHub
#270 (comment).

redboltz added a commit that referenced this pull request Apr 20, 2015
Inhibited wrong occurrence of ad-hoc encoding of 64bit doubles on iOS
@redboltz
redboltz merged commit 2919033 into msgpack:master Apr 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants