Serialization of 64-bit floats broken on iOS ARM 32-bit

[darknoon]

This has to do with the __ARM_EABI__ conditional in unpack_template.h / pack_template.h.

If I set a build setting __ARM_EABI__ = 1, then it works, but this kinda sucks. Is there another way to conditionalize this hack for that platform without messing up the build for iOS?

[redboltz]

Thank you for reporting the problem. The ARM_EABI conditional in unpack_template.h and pack_template.h are required for dispatch the proccess ARM EABI / OABI.

I don't have iOS developing environment. I asked some iOS developers.The macro ARM_EABI is not defined on iOS developing environment. I don't know why, and I think that ARM_EABI should be defined is the platform is EABI. If we could get some different predefined macro for iOS, I would implement using it.

Any ideas?

[rggjan]

Maybe a different endianness check like this one would be more robust:
http://stackoverflow.com/a/12792301/369009

Alternatively, a patch along these lines:
https://code.google.com/p/v8/issues/attachmentText?id=1312&aid=13120010000&name=v8-ios.patch&token=704fa2b9305af97f5c33d2aaad55fb30

Might also work:
-#if defined(arm) && !defined(ARM_EABI)
+#if defined(arm) && !defined(APPLE) && !defined(ARM_EABI)

[redboltz]

This issue has been fixed by #270