Fix Architecture.Tests xUnit v3 post-migration failures (#179) - #185
Conversation
- All 11 architecture tests pass with xUnit v3 3.2.2 (0 failures) - Updated Gimli history.md with Sprint 8 Wave 2 migration learnings Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
added
the
squad
🏗️ PR Added to Squad Triage QueueThis PR has been labeled with Next steps:
|
There was a problem hiding this comment.
Pull request overview
Records the post-migration validation results for the Architecture.Tests xUnit v3 migration, noting that no test failures were found.
Changes:
- Appends Sprint 8 Wave 2 learnings and validation notes for Architecture.Tests xUnit v3 migration to Gimli’s history log.
| 1. For MyBlog test coverage, a `ConfigureAwait(false)` cleanup in a MediatR pipeline behavior is non-observable unless tests explicitly assert synchronization-context behavior. | ||
| 2. Scope discipline matters here: do not churn nearby tests for unrelated convention gaps when the requested review is only about async continuation configuration. No newline at end of file | ||
| 2. Scope discipline matters here: do not churn nearby tests for unrelated convention gaps when the requested review is only about async continuation configuration. | ||
| ## 2025 — Sprint 8 Wave 2: Architecture.Tests xUnit v3 Migration (#178 / #179) |
There was a problem hiding this comment.
The new entry heading uses a different date format ("## 2025 — ...") than the rest of this history file (e.g., "## 2026-04-24 — ..." at line 274, and earlier entries at lines 149/161). It also appears out of chronological order since it comes after 2026-04-24. Consider updating the heading to the standard YYYY-MM-DD format and using the correct date/year so the timeline remains consistent.
| ## 2025 — Sprint 8 Wave 2: Architecture.Tests xUnit v3 Migration (#178 / #179) | |
| ## 2026-04-25 — Sprint 8 Wave 2: Architecture.Tests xUnit v3 Migration (#178 / #179) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## sprint/8-xunit-v3-pilot #185 +/- ##
==========================================================
Coverage ? 72.53%
==========================================================
Files ? 43
Lines ? 721
Branches ? 112
==========================================================
Hits ? 523
Misses ? 149
Partials ? 49 🚀 New features to boost your workflow:
|
Summary
Post-migration validation for Architecture.Tests xUnit v3 migration. No failures found.
Closes #179
Working as Gimli (Tester)
Findings
After applying the xUnit v3 migration in PR #184, all 11 architecture tests pass with zero failures:
No fixes required. The Architecture.Tests migration in Wave 2 is clean.
Root Cause Analysis
xUnit v3 is fully backward-compatible for all patterns used in Architecture.Tests:
[Fact]— identical in v2 and v3 ✅.Should()— unchanged ✅IClassFixture/ICollectionFixturepatterns in use ✅IAsyncLifetime,SetupAttribute) ✅The only migration work was Gimli Rule #3 compliance (AAA comments), which is purely cosmetic
and cannot introduce test failures.
Deliverables
.squad/agents/gimli/history.mdgimli-xunit-v3-migration-pattern.mddecision (in local decisions inbox for Scribe)Prerequisite
This PR should merge after #184 is merged to
sprint/8-xunit-v3-pilot.