Migrate Architecture.Tests to xUnit v3 (#178) by mpaulosky · Pull Request #184 · mpaulosky/MyBlog

mpaulosky · 2026-04-26T13:20:47Z

Summary

Migrates Architecture.Tests test methods to xUnit v3 API conventions, following the Sprint 7 Domain.Tests pilot pattern.

Closes #178

Working as Gimli (Tester)

What Changed

All 4 test files updated with proper xUnit v3 migration conventions:

File	Tests	Change
`DomainLayerTests.cs`	4	AAA comments + extract `assembly` variable for clean Arrange/Act split
`VsaLayerTests.cs`	3	AAA comments + extract `domainAssembly` variable
`ThemeLayerTests.cs`	2	AAA comments
`CachingLayerTests.cs`	2	AAA comments

Total: 11 tests migrated

xUnit v3 API Observations

[Fact] attribute is identical in xUnit v2 and v3 — no attribute changes required
No async/await patterns in architecture tests — no lifecycle changes needed
No IClassFixture / ICollectionFixture — stateless tests, no collection changes needed
FluentAssertions .Should() works unchanged with xUnit v3
Parallelization via xunit.runner.json was already configured in Wave 1 (Add xUnit v3 packages to Architecture.Tests (#176) #182)

Pattern Reference (Sprint 7 Domain.Tests Pilot)

Followed the same approach as the Sprint 7 Domain.Tests migration:

xUnit v3 meta-package via <PackageReference Include="xunit.v3"/> ✅ (Wave 1)
xunit.runner.json with parallelizeAssembly: true ✅ (Wave 1)
Gimli Rule refactor: consolidate common usings into GlobalUsings.cs per project #3: AAA comments on all test methods ✅ (this PR)
Gimli Rule chore: remove Weather and Counter template leftovers #6: File headers present on all files ✅ (pre-existing)

Test Results

Passed! - Failed: 0, Passed: 11, Skipped: 0, Total: 11 — Architecture.Tests.dll
Passed! - Failed: 0, Passed: 42, Skipped: 0, Total: 42 — Domain.Tests.dll

Zero failures. Ready to merge to sprint/8-xunit-v3-pilot.

- Add AAA (Arrange/Act/Assert) comments to all 11 test methods - Extract assembly variable in DomainLayerTests for cleaner Arrange/Act split - No xUnit attribute changes needed — [Fact] is identical in v2 and v3 - Follows Sprint 7 Domain.Tests pilot pattern (FluentAssertions + xunit.v3) - All 11 architecture tests pass with xunit.v3 3.2.2 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

github-actions · 2026-04-26T13:20:55Z

🏗️ PR Added to Squad Triage Queue

This PR has been labeled with squad and added to the triage queue.

Next steps:

The squad Lead will review and assign to an appropriate team member
A squad:member label will be added after triage

If you know which squad member should handle this, you can add the appropriate squad:member label yourself.

## Summary Post-migration validation for Architecture.Tests xUnit v3 migration. No failures found. Closes #179 **Working as Gimli (Tester)** --- ## Findings After applying the xUnit v3 migration in PR #184, all 11 architecture tests pass with zero failures: ``` Passed! - Failed: 0, Passed: 11, Skipped: 0, Total: 11 — Architecture.Tests.dll (72ms) ``` **No fixes required.** The Architecture.Tests migration in Wave 2 is clean. ## Root Cause Analysis xUnit v3 is fully backward-compatible for all patterns used in Architecture.Tests: - `[Fact]` — identical in v2 and v3 ✅ - FluentAssertions `.Should()` — unchanged ✅ - NetArchTest.Rules builder chain — unchanged ✅ - No `IClassFixture` / `ICollectionFixture` patterns in use ✅ - No xUnit lifecycle overrides (`IAsyncLifetime`, `SetupAttribute`) ✅ The only migration work was Gimli Rule #3 compliance (AAA comments), which is purely cosmetic and cannot introduce test failures. ## Deliverables - ✅ Validated: 11 tests pass with xUnit v3 3.2.2 - ✅ Appended Sprint 8 Wave 2 learnings to `.squad/agents/gimli/history.md` - ✅ Drafted `gimli-xunit-v3-migration-pattern.md` decision (in local decisions inbox for Scribe) ## Prerequisite This PR should merge after #184 is merged to `sprint/8-xunit-v3-pilot`. Co-authored-by: Boromir <boromir@squad.dev> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Updates Architecture.Tests test methods to follow the repo’s xUnit v3 migration conventions (matching the earlier Domain.Tests pilot) without changing the underlying architectural rules being asserted.

Changes:

Added AAA (Arrange/Act/Assert) comments to all Architecture.Tests test methods.
Extracted local Assembly variables in domain-related tests to clarify Arrange vs Act separation.
Minor variable renames to align with consistent assertion style (result.IsSuccessful).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
tests/Architecture.Tests/DomainLayerTests.cs	Adds AAA structure and extracts `assembly` local for clearer Arrange/Act split.
tests/Architecture.Tests/VsaLayerTests.cs	Adds AAA comments, renames locals to `result`, extracts `domainAssembly` in one test.
tests/Architecture.Tests/ThemeLayerTests.cs	Adds AAA comments around NetArchTest rule execution.
tests/Architecture.Tests/CachingLayerTests.cs	Adds AAA comments around caching dependency rules and assertions.

Copilot · 2026-04-26T13:23:32Z

 	public void Features_Should_Not_Reference_Each_Other()
 	{
-		// BlogPosts slice should not reference UserManagement and vice versa
-		var blogPostsResult = Types.InAssembly(WebAssembly)
+		// Arrange / Act — BlogPosts slice should not reference UserManagement and vice versa
+		var result = Types.InAssembly(WebAssembly)
 				.That()


Features_Should_Not_Reference_Each_Other (and the new comment text) implies a two-way dependency check, but the current rule only verifies that types in MyBlog.Web.Features.BlogPosts don’t depend on MyBlog.Web.Features.UserManagement. Either add a second assertion for the reverse direction (UserManagement → BlogPosts) or rename/adjust the test name and comment to match the one-way check.

Copilot · 2026-04-26T13:23:32Z

 		var result = Types.InAssembly(WebAssembly)
 				.That()
 				.ResideInNamespace("MyBlog.Web.Components.Theme")
 				.Should()
 				.ResideInNamespace("MyBlog.Web.Components.Theme")


This test is effectively tautological: it filters to types already in MyBlog.Web.Components.Theme and then asserts those types reside in the same namespace, so it can’t fail if the namespace exists. Consider selecting theme components by a different predicate (e.g., name starts with "Theme" / assignable to ComponentBase) and asserting they reside in MyBlog.Web.Components.Theme.

Copilot · 2026-04-26T13:23:33Z

+		// Arrange
+		var assembly = typeof(BlogPost).Assembly;
+
+		// Act
+		var result = Types.InAssembly(assembly)


typeof(BlogPost).Assembly is repeated in each test method; consider extracting a single private static readonly Assembly DomainAssembly = typeof(BlogPost).Assembly; (or similar) at the class level to reduce duplication and keep the Arrange sections focused on test-specific setup.

codecov · 2026-04-26T13:24:46Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (sprint/8-xunit-v3-pilot@5f1f102). Learn more about missing BASE report.

Additional details and impacted files

@@                    Coverage Diff                     @@
##             sprint/8-xunit-v3-pilot     #184   +/-   ##
==========================================================
  Coverage                           ?   72.53%           
==========================================================
  Files                              ?       43           
  Lines                              ?      721           
  Branches                           ?      112           
==========================================================
  Hits                               ?      523           
  Misses                             ?      149           
  Partials                           ?       49

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI review requested due to automatic review settings April 26, 2026 13:20

github-actions Bot added the squad Squad triage inbox — Lead will assign to a member label Apr 26, 2026

Copilot started reviewing on behalf of mpaulosky April 26, 2026 13:21 View session

mpaulosky mentioned this pull request Apr 26, 2026

Fix Architecture.Tests xUnit v3 post-migration failures (#179) #185

Merged

mpaulosky merged commit 206605e into sprint/8-xunit-v3-pilot Apr 26, 2026
15 checks passed

mpaulosky deleted the squad/178-migrate-architecture-tests-xunit-v3 branch April 26, 2026 13:23

Copilot AI reviewed Apr 26, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate Architecture.Tests to xUnit v3 (#178) - #184

Migrate Architecture.Tests to xUnit v3 (#178)#184
mpaulosky merged 1 commit into
sprint/8-xunit-v3-pilotfrom
squad/178-migrate-architecture-tests-xunit-v3

mpaulosky commented Apr 26, 2026

Uh oh!

github-actions Bot commented Apr 26, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 26, 2026

Uh oh!

Copilot AI Apr 26, 2026

Uh oh!

Copilot AI Apr 26, 2026

Uh oh!

codecov Bot commented Apr 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

mpaulosky commented Apr 26, 2026

Summary

What Changed

xUnit v3 API Observations

Pattern Reference (Sprint 7 Domain.Tests Pilot)

Test Results

Uh oh!

github-actions Bot commented Apr 26, 2026

🏗️ PR Added to Squad Triage Queue

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 26, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 26, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 26, 2026

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Apr 26, 2026

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants