fix(docs): address Aragorn review blockers — PR #126 - #127
Merged
Conversation
- PR #62: APPROVE — pre-push hook logic verified, clean infra fix - PR #63: conditional APPROVE — build confirmation needed before merge - PR #60: NEEDS_CHANGES — dirty state, missing copyright headers, wrong attribution - Systemic finding: squad-test.yml does not trigger on sprint/** PRs Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Add push trigger for sprint/** so direct pushes to sprint branches trigger the parallel test suite - Add sprint/** to pull_request.branches so PRs targeting sprint consolidation branches also run CI validation Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Update .NET SDK to 10.0.202 in global.json - Add docs/build-log.txt with build & test results - Include refactored code improvements Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…learnings Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
GitVersion auto-increments on main; v1.0.0-sprint3 is final sprint tag. Subsequent releases follow pure semantic versioning from v1.0.1 onwards. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Marks cutover from sprint-based tags to pure semantic versioning. GitVersion auto-increments Patch on main. This release validates the new versioning workflow: - main commit → CI GitVersion tags → GitHub Release creation Closes: versioning decision from sprint/4-planning Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
When CI runs on main after merge, create and push the git tag based on GitVersion-determined semver. This enables v1.0.1, v1.0.2, etc. to be automatically tagged without manual intervention. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add step to CI workflow that creates and pushes git tags for each commit to main, using GitVersion-determined semver. This completes the v1.0.1 release flow: - Merge PR to main - CI determines version with GitVersion - CI creates and pushes tag (v1.0.1, v1.0.2, ...) - Team creates GitHub Release from tag Closes: versioning automation setup
GitVersion v4 action no longer accepts 'useConfigFile'. Use 'configFilePath' to explicitly specify the GitVersion.yml location. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Replace deprecated 'useConfigFile' with 'configFilePath' in GitVersion action. This is required for gittools/actions/gitversion/execute@v4 to work properly.
The 'Create and Push Git Tag' step requires 'contents: write' permission to push tags to the repository. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Change 'contents: read' to 'contents: write' so the 'Create and Push Git Tag' step can push tags. This completes the automatic versioning workflow.
semVer includes pre-release height on non-main branches, resulting in tags like v1.0.0-101. On main, we want clean semver tags like v1.0.1, which comes from the majorMinorPatch output. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
GitVersion's semVer output includes pre-release height (e.g.
v1.0.0-101).
On main, we want clean v1.0.1 format, which comes from majorMinorPatch.
This ensures the first post-sprint release is tagged v1.0.1, not
v1.0.0-{height}.
Document the new automatic versioning workflow with GitVersion. This is the first commit after v1.0.0, which will trigger v1.0.1 tag creation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add RELEASE.md documenting the new automatic versioning workflow. This commit on main will trigger v1.0.1 tag creation via the CI workflow.
Aligns with squad naming conventions and PRD specification. All squad-managed workflows use the 'squad-' prefix. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Align CI workflow naming with squad conventions. All squad-managed workflows use the 'squad-' prefix.
Merge dev into main for Sprint 4 release. Resolve workflow conflicts by accepting dev versions (squad-ci.yml, squad-test.yml). Also fix squad-preview validate to exclude AppHost.Tests/Bunit. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
## Sprint 4 Release — v1.1.0 Replaces PR #105 which had a merge conflict in workflow files (`squad-ci.yml`, `squad-test.yml`). ### Changes included All Sprint 4 work from `dev`: - feat: Blazor theme system (Sprint 4 issues #81–#86) - feat: VSA migration — move Domain.Features to Web (PR #104) - fix: Resolve all 7 flaky E2E tests in AppHost.Tests (PR #102) - refactor: Reorganize test projects (PR #100) - ci: Central Package Management (CPM) - ci: Fix squad-preview validate to skip AppHost.Tests/Bunit (unrunnable on plain runners) ### Conflict resolution `squad-ci.yml` and `squad-test.yml` had add/add and content conflicts from main having an older version. Resolved by accepting the `dev` versions (correct current state). --- Closes #105 _After merging, run **squad-milestone-release** to tag and publish v1.1.0._
## Sprint 5 Release — Redis & Caching (v1.2.0) Promotes `dev` → `main` for the Sprint 5 release. ### What's in this release - **`IBlogPostCacheService`** — caching contract with `GetOrFetchAllAsync`, `GetOrFetchByIdAsync`, `InvalidateAllAsync`, `InvalidateByIdAsync` - **`BlogPostCacheService`** — two-tier L1 (IMemoryCache, 1-min TTL) + L2 (Redis, 5-min TTL), registered as Singleton via `AddBlogPostCaching()` - All 4 BlogPost MediatR handlers refactored to inject `IBlogPostCacheService` only - 16 unit tests, 2 arch tests, 3 Redis integration tests (Testcontainers) - ADR: `docs/adr/sprint5-caching-abstraction.md` - CI: auto-move Done → Released on GitHub Release publish ### Closed issues Closes #109, #110, #111, #112, #113, #114 ### CI status All checks green on `dev` ✅
Fixes literal block scalar indentation in project-board-automation.yml, add-issues-to-project.yml, and squad-test.yml. All CI checks green.
- docs/index.html: fix npm script name css:watch → tw:watch - README.md: add BLOG_START/END markers for blog-readme-sync automation - README.md + kickoff blog: correct Aspire version 13.2.2 → 13.2.3 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
🏗️ PR Added to Squad Triage QueueThis PR has been labeled with Next steps:
|
github-actions
Bot
added
the
squad
There was a problem hiding this comment.
Pull request overview
This PR updates documentation to address review blockers from PR #126 by correcting TailwindCSS watch script instructions and aligning documented .NET Aspire version with the repo’s centrally-managed package versions.
Changes:
- Update GitHub Pages docs to use
npm run tw:watch(correct Tailwind watch script). - Bump documented .NET Aspire version from
13.2.2to13.2.3in README and the Sprint 1 kickoff blog post. - Add a README “Dev Blog” section with
<!-- BLOG_START -->/<!-- BLOG_END -->markers and a recent-posts table.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/index.html | Fixes Tailwind watch command to match repo npm scripts (tw:watch). |
| docs/blog/2026-04-18-myblog-project-kickoff.md | Updates documented Aspire version to 13.2.3. |
| README.md | Updates Aspire version to 13.2.3 and adds a “Dev Blog” section/table. |
Comment on lines
+166
to
+170
| ## Dev Blog | ||
|
|
||
| <!-- BLOG_START --> | ||
| | Date | Title | Tags | | ||
| |------|-------|------| |
There was a problem hiding this comment.
The PR description only mentions updating the Tailwind watch script name and bumping the Aspire version, but this change also adds a new "Dev Blog" section (with BLOG_START/BLOG_END markers and a table) to the README. Please either update the PR description to include this additional change or move it to a separate PR to keep scope aligned with the stated review blockers.
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #127 +/- ##
=======================================
Coverage 76.93% 76.93%
=======================================
Files 43 43
Lines 672 672
Branches 111 111
=======================================
Hits 517 517
Misses 105 105
Partials 50 50 🚀 New features to boost your workflow:
|
Owner
Author
🔱 Aragorn — APPROVED ✅CI: ✅ All checks passed | Copilot review: ✅ Read
Copilot's PR-description scope note is non-blocking. All 3 blockers resolved. Merging. — Aragorn |
Comment on lines
+166
to
+170
| ## Dev Blog | ||
|
|
||
| <!-- BLOG_START --> | ||
| | Date | Title | Tags | | ||
| |------|-------|------| |
There was a problem hiding this comment.
The PR description lists only the Tailwind watch script rename and Aspire version bump, but this diff also adds a new "Dev Blog" section (BLOG_START/BLOG_END) to the README. Please update the PR description to reflect this additional change (or split it into a separate PR if it’s out of scope).
Owner
Author
🔱 Aragorn — Approved ✅Verification against PR #126 blockers:
CI: ✅ All 15 checks pass All three review blockers addressed cleanly. Merging. 🚀 |
mpaulosky
added a commit
that referenced
this pull request
Apr 24, 2026
…itHub Pages Promotes v1.2.0 documentation from dev to main: - 6 new blog posts (Sprints 1–5 + release milestones v1.0.0/v1.1.0/v1.2.0) in docs/blog/ - docs/blog/index.md — blog landing page with Latest Posts table (blog-readme-sync compatible) - README.md — full rewrite for v1.2.0 stack (Aspire 13.2.3, Redis, bUnit, 7 test projects) - Dev Blog section with BLOG_START/BLOG_END markers for automated sync - Release history table (v1.0.0 → v1.2.0) - docs/index.html — GitHub Pages overhauled for v1.2.0 (release table, blog links, npm tw:watch) - Workflow YAML heredoc indentation hardening (3 workflow files) Fixes from PR #127 included: correct npm script (tw:watch), blog-sync markers, Aspire 13.2.3. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes 3 blocking issues flagged by Aragorn in review of PR #126:
docs/index.html—npm run css:watch→npm run tw:watch(correct script name)README.md+docs/blog/2026-04-18-myblog-project-kickoff.md— Aspire version13.2.2→13.2.3