ci: grant write permissions for tag creation - #90
Merged
Conversation
The 'Create and Push Git Tag' step requires 'contents: write' permission to push tags to the repository. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
🏗️ PR Added to Squad Triage QueueThis PR has been labeled with Next steps:
|
github-actions
Bot
added
the
squad
Contributor
SummarySummary
CoverageAppHost - 0%
Domain - 87.2%
ServiceDefaults - 0%
Web - 68.7%
|
Contributor
|
There was a problem hiding this comment.
Pull request overview
This PR updates the CI workflow permissions to allow the workflow’s “Create and Push Git Tag” step to push tags back to the repository, completing the automatic versioning/tagging flow on push to main.
Changes:
- Update GitHub Actions job permissions from
contents: readtocontents: writein CI.
|
|
||
| permissions: | ||
| contents: read | ||
| contents: write |
There was a problem hiding this comment.
Granting contents: write at the job level applies to both pull_request and push triggers. That means PR runs (including code from feature branches) receive a write-capable GITHUB_TOKEN, which increases the blast radius (e.g., a compromised PR could push refs/tags/commits). Consider keeping contents: read for the build/test job and moving tag creation into a separate job (or separate workflow) that runs only on push to main with permissions: contents: write and needs: build-and-test.
Suggested change
| contents: write | |
| contents: read |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change 'contents: read' to 'contents: write' so the 'Create and Push Git Tag' step can push tags.
This completes the automatic versioning workflow.