RUBY-3910 Skip time-sensitive CSOT change stream tests on 9.0+ sharded#3092
Open
jamis wants to merge 2 commits into
Open
RUBY-3910 Skip time-sensitive CSOT change stream tests on 9.0+ sharded#3092jamis wants to merge 2 commits into
jamis wants to merge 2 commits into
Conversation
The 9.0 server can delay opening a current-time change stream (SPM-1941), which races against sub-1s timeoutMS values and causes spurious failures on sharded clusters. Sync the spec fixtures that split the affected createChangeStream tests into replicaset and sharded (maxServerVersion 8.99) requirements. From DRIVERS-3556 spec PRs mongodb#1962 and mongodb#1964.
Contributor
There was a problem hiding this comment.
Pull request overview
Synchronizes Client-Side Operations Timeout (CSOT) unified spec fixtures to avoid time-sensitive createChangeStream tests running on MongoDB 9.0+ sharded clusters, where server behavior can cause spurious timeouts.
Changes:
- Split affected
createChangeStreamtestrunOnRequirementsentries into:- a replica set requirement (still runs on 9.0+ replica sets), and
- a sharded requirement capped with
maxServerVersion: "8.99"(skips sharded 9.0+).
- Apply this fixture change across the CSOT
timeoutMSand legacy timeout retryability/override YAMLs where current-time change streams are opened.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| spec/spec_tests/data/client_side_operations_timeout/retryability-timeoutMS.yml | Split createChangeStream retryability test requirements to skip sharded 9.0+. |
| spec/spec_tests/data/client_side_operations_timeout/retryability-legacy-timeouts.yml | Add per-test requirements for createChangeStream legacy-timeout retryability tests to skip sharded 9.0+. |
| spec/spec_tests/data/client_side_operations_timeout/override-operation-timeoutMS.yml | Add per-test requirements for createChangeStream operation-level override tests to skip sharded 9.0+. |
| spec/spec_tests/data/client_side_operations_timeout/override-database-timeoutMS.yml | Add per-test requirements for createChangeStream database-level override tests to skip sharded 9.0+. |
| spec/spec_tests/data/client_side_operations_timeout/override-collection-timeoutMS.yml | Add per-test requirements for createChangeStream collection-level override test to skip sharded 9.0+. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Sync the CSOT spec fixtures from DRIVERS-3556 (spec PRs #1962 and #1964).
On 9.0+ sharded clusters, opening a current-time change stream can block until the config server's cluster time advances past the open time (intentional SPM-1941 behavior). This races against the sub-1s
timeoutMSvalues these tests use, producing spurious failures in CI. The spec addressed it by splitting the affectedcreateChangeStreamtests'runOnRequirementsinto a replicaset entry and a sharded entry capped atmaxServerVersion: "8.99", so they no longer run on 9.0+ sharded topologies.This PR mirrors those changes into
spec/spec_tests/data/client_side_operations_timeout/— 11 test cases across 5 files:override-operation-timeoutMS.yml(client, database, collection)override-collection-timeoutMS.yml(collection)override-database-timeoutMS.yml(database, collection)retryability-legacy-timeouts.yml(client, database, collection)retryability-timeoutMS.yml(client, database, collection)The driver consumes these
.ymlfixtures directly, so no runner or template changes are needed.Testing
Ran the full CSOT suite against a local 9.0.0-rc0 replica set (
CSOT_SPEC_TESTS=1). The edited change-stream tests still run on the replica set (skips only apply to sharded) and pass. The one unrelated failure (deprecated-options.ymlmaxTimeMS/aggregate) is pre-existing and independent of these changes.