RUBY-2165 Yield client to block from constructor#1964
Merged
Conversation
neilshweky
requested review from
egiurleo and
p-mongo
and removed request for
egiurleo
June 18, 2020 15:30
Contributor
Author
|
I tested that the client closed for a base case of the client... I didn't think the complicated client configurations affect this ticket... |
p-mongo
reviewed
Jun 18, 2020
p-mongo
reviewed
Jun 18, 2020
p-mongo
approved these changes
Jun 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix itself was only a 2-3 line fix... but the testing was the real kicker. The tests work, but I modified a lot more code than maybe necessary... Let me know if I need to fix that.