Skip to content

docs: record B1–B16 remediation in the 2026-06-12 code-audit findings #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lesnik512 merged 1 commit into from
Jun 13, 2026
Merged

docs: record B1–B16 remediation in the 2026-06-12 code-audit findings #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 29 additions & 1 deletion planning/active/2026-06-12-code-audit-findings.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
---
date: 2026-06-12
scope: faststream_outbox/ (package) + tests/ (test quality)
status: triage
status: bugs-remediated # B1-B16 fixed in PR #61; suspected/test-holes/improvements still open
bugs_pr: 61
bugs_remediated: 2026-06-13
---

# Code audit findings — 2026-06-12
Expand All @@ -27,6 +29,32 @@ Severity tiers: **bug** (confirmed wrong behavior), **suspected**
invariant the 100%-coverage suite does not actually pin — named by the
mutation that survives), **improvement**.

## Remediation status (2026-06-13)

**All 16 confirmed bugs (B1–B16) are fixed in PR #61** (branch `worktree-fix-audit-bugs-b1-b16`, commit `74f8554`). Each fix ships a
regression test verified red on the pre-fix code where mechanically feasible.
Verification: full dockerized suite (Postgres 17) **423 passed** (was 401 — 22 new
tests), the **100% coverage** gate met, `ruff format`/`ruff check`/`ty check` clean.

Implementation followed the audit's suggested directions: B5/B6/B7 accept-and-ignore
`**options` on ack/nack/reject, the manual-fallback nacks (honors retry) when
`last_exception` is set, a raising retry strategy degrades to `retry_terminal`, and
`ExponentialRetry` clamps the exponent (`_MAX_DELAY_SECONDS` ceiling). B8 overrides
`OutboxPublishCommand.batch_bodies`. B10 uses `format_table` + `MetaData(schema=...)`.

Two notes worth recording:

* The first B5 regression test passed for the **wrong reason** — a handler typed
`msg: OutboxMessage` never had the message injected, so the body never ran and a
DI exception (not the intended `raise`) drove the retry. Coverage caught it; the
handler is now body-based and genuinely exercises "MANUAL + handler exception".
* B13's missing-extra import path can't be exercised under the all-extras CI (the
audit itself flagged this); the fix is structural — the new `else`/`except`
branches carry `# pragma: no cover`.

**Still open** (out of scope for PR #61): suspected S1–S5, test-holes T1–T8, the
additional test findings, improvements P1–P35, and the doc / CLAUDE.md drift items.

## Summary — bugs

| ID | Where | One-liner | Verified |
Expand Down