fix: streamline environment retrieval in venvManager and pyenvManager#1157
Merged
karthiknadig merged 2 commits intomainfrom Feb 3, 2026
Merged
fix: streamline environment retrieval in venvManager and pyenvManager#1157karthiknadig merged 2 commits intomainfrom
karthiknadig merged 2 commits intomainfrom
Conversation
TylerLeonhardt
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #610
Summary
This PR enables pyenv-installed Python versions to appear as available base interpreters when creating new venv environments.
Changes
1. Fixed bug in
PyEnvManager.getEnvironments()The filter callback for the
'global'scope was missing a return statement - it used braces without returning a value, causing it to always return an empty array:2. Updated
VenvManagerto use API for aggregating global environmentsChanged from using only
baseManager.getEnvironments('global')(which only returns system Python) toapi.getEnvironments('global')which aggregates environments from ALL registered managers including pyenv, conda, etc.This change was applied to three locations in
venvManager.ts:create()method - when showing available base interpreters for venv creationresetGlobalEnv()method - when resetting the global environment referenceloadEnvMap()method - when loading environment mappingsResult
When users create a new venv environment, pyenv-installed Python versions (those in the
PYENV_VERSIONSgroup) will now appear alongside system Python installations as available base interpreters.