Skip to content

Add outstanding test improver coverage - #10070

Merged
Evangelink merged 7 commits into
mainfrom
dev/amauryleve/address-test-improver-issues
Jul 20, 2026
Merged

Add outstanding test improver coverage#10070
Evangelink merged 7 commits into
mainfrom
dev/amauryleve/address-test-improver-issues

Conversation

@Evangelink

@Evangelink Evangelink commented Jul 20, 2026

Copy link
Copy Markdown
Member

Summary

Validation

  • build.cmd -binaryLog
  • targeted MSTest.Analyzers builds: 0 warnings and 0 errors
  • focused MSTest.Analyzers unit-test classes pass

Closes #9717
Closes #9837
Closes #9919
Closes #9952
Closes #10027
Closes #10049
Closes #10050
Closes #10058
Closes #10059
Closes #10064

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 28567541-d476-4300-a979-3c1fb89404c2
Copilot AI review requested due to automatic review settings July 20, 2026 07:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds edge-case coverage for four MSTest analyzer rules.

Changes:

  • Tests MSTEST0028 and MSTEST0038 boundary behavior.
  • Covers delegate inputs for MSTEST0051.
  • Adds C# ref readonly coverage for MSTEST0062.
Show a summary per file
File Description
NonNullableReferenceNotInitializedSuppressorTests.cs Tests field and getter-only property suppression boundaries.
AvoidOutRefTestMethodParametersAnalyzerTests.cs Adds ref readonly parameter coverage.
AvoidAssertAreSameWithValueTypesAnalyzerTests.cs Tests null and generic arguments.
AssertThrowsShouldContainSingleStatementAnalyzerTests.cs Tests method-group and delegate inputs.

Review details

  • Files reviewed: 4/4 changed files
  • Comments generated: 2
  • Review effort level: Medium

@github-actions

This comment has been minimized.

@Evangelink
Evangelink enabled auto-merge (squash) July 20, 2026 08:07
@Evangelink
Evangelink disabled auto-merge July 20, 2026 08:07
@Evangelink
Evangelink enabled auto-merge (squash) July 20, 2026 08:07
@Evangelink Evangelink added the state/needs-review Awaiting review from the team. label Jul 20, 2026
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 28567541-d476-4300-a979-3c1fb89404c2
Copilot AI review requested due to automatic review settings July 20, 2026 08:14

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 6/6 changed files
  • Comments generated: 3
  • Review effort level: Medium

@github-actions

This comment has been minimized.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 28567541-d476-4300-a979-3c1fb89404c2
Copilot AI review requested due to automatic review settings July 20, 2026 08:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 7/7 changed files
  • Comments generated: 0 new
  • Review effort level: Medium

@github-actions

This comment has been minimized.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 28567541-d476-4300-a979-3c1fb89404c2
Copilot AI review requested due to automatic review settings July 20, 2026 08:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 7/7 changed files
  • Comments generated: 1
  • Review effort level: Medium

Comment thread src/Analyzers/MSTest.Analyzers/AvoidOutRefTestMethodParametersAnalyzer.cs Outdated
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 28567541-d476-4300-a979-3c1fb89404c2
Copilot AI review requested due to automatic review settings July 20, 2026 08:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 7/7 changed files
  • Comments generated: 2
  • Review effort level: Medium

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 28567541-d476-4300-a979-3c1fb89404c2
Copilot AI review requested due to automatic review settings July 20, 2026 08:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 7/7 changed files
  • Comments generated: 1
  • Review effort level: Medium

Comment thread src/Analyzers/MSTest.Analyzers.CodeFixes/AvoidOutRefTestMethodParametersFixer.cs Outdated
@github-actions

This comment has been minimized.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 28567541-d476-4300-a979-3c1fb89404c2
Copilot AI review requested due to automatic review settings July 20, 2026 08:49

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 7/7 changed files
  • Comments generated: 0 new
  • Review effort level: Medium

@github-actions

Copy link
Copy Markdown
Contributor

🧪 Test quality grade — PR #10070

GradeTestNotes
A (90–100) new AvoidOutRefTestMethodParametersAnalyzerTests.
WhenRefReadonlyModifiersContainComment_
CodeFixPreservesComment
Clean end-to-end code-fix assertion with focused before/after snippets — no issues found.

This advisory comment was generated automatically. Grades are heuristic
and informational — they do not block merging. Re-run with
/grade-tests.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"

See Network Configuration for more information.

🤖 Automated content by GitHub Copilot. Generated by the Grade Tests on PR (on open / sync) workflow. · 44.7 AIC · ⌖ 4.81 AIC · ⊞ 8.9K · [◷]( · )

@Evangelink
Evangelink merged commit e26b213 into main Jul 20, 2026
39 checks passed
@Evangelink
Evangelink deleted the dev/amauryleve/address-test-improver-issues branch July 20, 2026 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment