Skip to content

Add MSTEST0070 member name edge-case tests - #10031

Merged
Evangelink merged 3 commits into
mainfrom
dev/amauryleve/test-mstest0070-edge-cases
Jul 17, 2026
Merged

Add MSTEST0070 member name edge-case tests#10031
Evangelink merged 3 commits into
mainfrom
dev/amauryleve/test-mstest0070-edge-cases

Conversation

@Evangelink

@Evangelink Evangelink commented Jul 17, 2026

Copy link
Copy Markdown
Member

Summary

  • cover empty member names in MemberConditionShouldBeValidAnalyzer
  • cover whitespace-only member names
  • cover an empty member name after a valid entry in the params array
  • stabilize the unrelated Windows net462 cancellation test exposed by CI by replacing its timer race with explicit cancellation

Validation

  • all 28 MemberConditionShouldBeValidAnalyzerTests pass
  • targeted CancellationAsyncWithReturnValue_ObserveException_Succeeds passes on net462
  • the cancellation test passes 10 consecutive net462 runs

Fixes #10026

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: fb77a624-ff12-4dda-849c-882199b9830e
Copilot AI review requested due to automatic review settings July 17, 2026 08:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds MSTEST0070 regression coverage for member names ignored by the analyzer because runtime validation handles them.

Changes:

  • Tests empty and whitespace-only member names.
  • Tests an empty name within the additional params array.
  • Verifies all cases produce no analyzer diagnostic.
Show a summary per file
File Description
test/UnitTests/MSTest.Analyzers.UnitTests/MemberConditionShouldBeValidAnalyzerTests.cs Adds three edge-case analyzer tests.

Review details

  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Medium

@github-actions

This comment has been minimized.

@Evangelink
Evangelink enabled auto-merge (squash) July 17, 2026 08:41
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: fb77a624-ff12-4dda-849c-882199b9830e
Copilot AI review requested due to automatic review settings July 17, 2026 11:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 2/2 changed files
  • Comments generated: 1
  • Review effort level: Medium

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: fb77a624-ff12-4dda-849c-882199b9830e
Copilot AI review requested due to automatic review settings July 17, 2026 12:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 2/2 changed files
  • Comments generated: 0 new
  • Review effort level: Medium

@github-actions

Copy link
Copy Markdown
Contributor

Test quality grade - PR #10031

GradeTestNotes
A (90-100) mod TaskExtensionsTests.
CancellationAsyncWithReturnValue_
ObserveException_
Succeeds
Exception assertion + token equality + sync verification; pragma-only change preserves an already solid test.

This advisory comment was generated automatically. Grades are heuristic and informational - they do not block merging. Re-run with /grade-tests.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"

See Network Configuration for more information.

🤖 Automated content by GitHub Copilot. Generated by the Grade Tests on PR (on open / sync) workflow. · 40.1 AIC · ⌖ 6.1 AIC · ⊞ 8.9K · [◷]( · )

@Evangelink Evangelink added the state/needs-review Awaiting review from the team. label Jul 17, 2026
@Evangelink
Evangelink merged commit 94d22e4 into main Jul 17, 2026
39 checks passed
@Evangelink
Evangelink deleted the dev/amauryleve/test-mstest0070-edge-cases branch July 17, 2026 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state/needs-review Awaiting review from the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[test-improver] Add edge-case tests for MemberConditionShouldBeValidAnalyzer (MSTEST0070)

3 participants