[Table Improvements] Align list in table cells#3275
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds alignment support for list items within table cells. When applying horizontal alignment to table cells containing list items, the alignment now propagates to the list items themselves, ensuring consistent formatting.
Changes:
- Extended
alignTableCellHorizontallyto apply text alignment to list items within table cells - Maintained existing behavior of removing paragraph-level text align properties
- Added comprehensive test coverage for list item alignment in various scenarios (LTR, RTL, mixed content)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/roosterjs-content-model-api/lib/modelApi/table/alignTableCell.ts | Added logic to apply alignment to ListItem blocks and moved paragraph textAlign removal logic into the alignment callback |
| packages/roosterjs-content-model-api/test/modelApi/table/alignTableCellTest.ts | Added comprehensive test cases for list item alignment in table cells, including RTL scenarios and mixed content |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| for (const block of cell.blocks) { | ||
| if (block.blockType === 'Paragraph' && block.format.textAlign) { | ||
| delete mutateBlock(block).format.textAlign; | ||
| } else if (block.blockType == 'BlockGroup' && block.blockGroupType == 'ListItem') { |
There was a problem hiding this comment.
Inconsistent equality operator used. Line 52 uses strict equality (===) for blockType comparison, but this line uses loose equality (==) for both blockType and blockGroupType comparisons. For consistency and to avoid potential type coercion issues, use strict equality (===) for both comparisons on this line.
| } else if (block.blockType == 'BlockGroup' && block.blockGroupType == 'ListItem') { | |
| } else if (block.blockType === 'BlockGroup' && block.blockGroupType === 'ListItem') { |
| alignTableCellInternal(table, cell => { | ||
| cell.format.textAlign = | ||
| const alignment = | ||
| TextAlignValueMap[operation][cell.format.direction == 'rtl' ? 'rtl' : 'ltr']; |
There was a problem hiding this comment.
Inconsistent equality operator used. For consistency with line 52 which uses strict equality (===), this comparison should also use strict equality (===) instead of loose equality (==).
| TextAlignValueMap[operation][cell.format.direction == 'rtl' ? 'rtl' : 'ltr']; | |
| TextAlignValueMap[operation][cell.format.direction === 'rtl' ? 'rtl' : 'ltr']; |
* Fix publish file (#3267) * fix publish file * remove file * [Table Improvements] Add undoSnapshot when tab on a table cell (#3265) Add undoSnapshot after pressing Tab key in a table that has new content, otherwise if the user type content in a table and press tab to move to another cell and then undo the content, all the typed content will be removed. * [Table Improvements] Use keyboard to delete rows and columns (#3270) When press backspace or shift + delete when an entire row or column, delete the column and row. * [Table Improvements] Add Shift Cells Table Operation (#3271) Add new shift cells up and shift cells left table operations. These operations move the table cell content to the cells at left or above. * align table cell list (#3275) When apply alignment in table cells that has list items, also apply the alignment to the list items. * fill gaps (#3272) * Bump lodash from 4.17.21 to 4.17.23 (#3266) Bumps [lodash](https://github.com/lodash/lodash) from 4.17.21 to 4.17.23. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.21...4.17.23) --- updated-dependencies: - dependency-name: lodash dependency-version: 4.17.23 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jiuqing Song <jisong@microsoft.com> * fix table format (#3277) When triggering clearFormat on table cells, do not clear the cell or the table format. * [Table Improvements] Add preview for table cell selection (#3274) When start shadow edit, check if table cells are selected, if they are selected, remove the background color to make the styles changes visible in the table. * Fix outdated JSDoc comments in setTableCellsStyle.ts (#3278) Fix JSDoc comments for removeTableCellsStyle function to match actual parameters Fix JSDoc comments for setTableCellsStyle function to match actual parameters * Fix 329516 (#3276) Co-authored-by: Bryan Valverde U <bvalverde@microsoft.com> * [Table Improvements] Insert table content (#3258) When inserting a table in a range selection, insert the selected content inside the table. * Bump webpack from 5.94.0 to 5.104.1 (#3285) Bumps [webpack](https://github.com/webpack/webpack) from 5.94.0 to 5.104.1. - [Release notes](https://github.com/webpack/webpack/releases) - [Changelog](https://github.com/webpack/webpack/blob/main/CHANGELOG.md) - [Commits](webpack/webpack@v5.94.0...v5.104.1) --- updated-dependencies: - dependency-name: webpack dependency-version: 5.104.1 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Filter temporary EOP elements in Word Online paste and add test pattern support (#3283) * Filter temporary EOP elements in Word Online paste and add test pattern support - Skip elements with both 'Selected' and 'EOP' classes during WAC paste processing to remove temporary End of Paragraph markers - Add unit tests for EOP element filtering behavior (3 test cases) - Enhance test runner with --testPathPattern and --testNamePattern flags for faster targeted test execution 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * Update packages/roosterjs-content-model-plugins/lib/paste/WacComponents/processPastedContentWacComponents.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Dark color improvement (#3279) * Dark color improvement * improve * Fix #3280 (#3282) * [Table Improvements] Ignore span cells when merge table cells (#3281) When merging table cells, count table that are span as one cell, so two or more cells cannot be merge to one single span cell. * Bump main and legacyAdapter versions in versions.json --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Julia Roldi <87443959+juliaroldi@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jiuqing Song <jisong@microsoft.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
When apply alignment in table cells that has list items, also apply the alignment to the list items.
