[Table Improvements] Insert table content by juliaroldi · Pull Request #3258 · microsoft/roosterjs

juliaroldi · 2026-01-14T20:05:02Z

When inserting a table in a range selection, insert the selected content inside the table.

JiuqingSong · 2026-01-16T17:56:20Z

packages/roosterjs-content-model-api/lib/publicApi/table/insertTable.ts

    editor.formatContentModel(
        (model, context) => {
-            const insertPosition = deleteSelection(model, [], context).insertPoint;
+            const copiedModel = cloneModel(model);


curious why we need to clone a model?

I used the cloned model, because it returns the content model types, not readonly types, making it easier to insert the content into the table that is ContentModelTable type.

Could we iterate the selected blocks, mutate them and then store them in an array？ If the model is very big we would need to iterate everything to clone it.

JiuqingSong · 2026-01-16T17:56:47Z

packages/roosterjs-content-model-api/lib/publicApi/table/insertTable.ts

+        }
+
+        if (path.length == 1 && block) {
+            table.rows[index].cells[0].blocks = [block];


what if only part of a block is selected? Do we still expect to insert the whole block into table?

JiuqingSong · 2026-01-16T17:58:11Z

packages/roosterjs-content-model-api/lib/publicApi/table/insertTable.ts

    }
 }
+
+function insertTableContent(


This looks more like a model API, so you can create a separate file under modelAPI folder

JiuqingSong · 2026-02-04T22:09:45Z

packages/roosterjs-content-model-api/lib/modelApi/table/tableContent.ts

+/**
+ * @internal
+ */
+export function getSelectedContent(


This seems similar with packages\roosterjs-content-model-core\lib\command\cutCopy\getContentForCopy.ts, can you reuse?

…m/microsoft/roosterjs into u/juliaroldi/insert-table-content

JiuqingSong · 2026-02-05T18:49:42Z

packages/roosterjs-content-model-dom/lib/domUtils/selection/getSelectedModel.ts

+ * @param model the model document
+ * @param selection The editor selection
+ * */
+export function getSelectedModel(


This name is confusing. Normally a function named "get**" will not modify the input object. Here it actually removes unselected contents, so better name it something like trimModelForSelection.

And then no need to return model since we can directly get it from the parameter.

* Fix publish file (#3267) * fix publish file * remove file * [Table Improvements] Add undoSnapshot when tab on a table cell (#3265) Add undoSnapshot after pressing Tab key in a table that has new content, otherwise if the user type content in a table and press tab to move to another cell and then undo the content, all the typed content will be removed. * [Table Improvements] Use keyboard to delete rows and columns (#3270) When press backspace or shift + delete when an entire row or column, delete the column and row. * [Table Improvements] Add Shift Cells Table Operation (#3271) Add new shift cells up and shift cells left table operations. These operations move the table cell content to the cells at left or above. * align table cell list (#3275) When apply alignment in table cells that has list items, also apply the alignment to the list items. * fill gaps (#3272) * Bump lodash from 4.17.21 to 4.17.23 (#3266) Bumps [lodash](https://github.com/lodash/lodash) from 4.17.21 to 4.17.23. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.21...4.17.23) --- updated-dependencies: - dependency-name: lodash dependency-version: 4.17.23 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jiuqing Song <jisong@microsoft.com> * fix table format (#3277) When triggering clearFormat on table cells, do not clear the cell or the table format. * [Table Improvements] Add preview for table cell selection (#3274) When start shadow edit, check if table cells are selected, if they are selected, remove the background color to make the styles changes visible in the table. * Fix outdated JSDoc comments in setTableCellsStyle.ts (#3278) Fix JSDoc comments for removeTableCellsStyle function to match actual parameters Fix JSDoc comments for setTableCellsStyle function to match actual parameters * Fix 329516 (#3276) Co-authored-by: Bryan Valverde U <bvalverde@microsoft.com> * [Table Improvements] Insert table content (#3258) When inserting a table in a range selection, insert the selected content inside the table. * Bump webpack from 5.94.0 to 5.104.1 (#3285) Bumps [webpack](https://github.com/webpack/webpack) from 5.94.0 to 5.104.1. - [Release notes](https://github.com/webpack/webpack/releases) - [Changelog](https://github.com/webpack/webpack/blob/main/CHANGELOG.md) - [Commits](webpack/webpack@v5.94.0...v5.104.1) --- updated-dependencies: - dependency-name: webpack dependency-version: 5.104.1 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Filter temporary EOP elements in Word Online paste and add test pattern support (#3283) * Filter temporary EOP elements in Word Online paste and add test pattern support - Skip elements with both 'Selected' and 'EOP' classes during WAC paste processing to remove temporary End of Paragraph markers - Add unit tests for EOP element filtering behavior (3 test cases) - Enhance test runner with --testPathPattern and --testNamePattern flags for faster targeted test execution 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * Update packages/roosterjs-content-model-plugins/lib/paste/WacComponents/processPastedContentWacComponents.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Dark color improvement (#3279) * Dark color improvement * improve * Fix #3280 (#3282) * [Table Improvements] Ignore span cells when merge table cells (#3281) When merging table cells, count table that are span as one cell, so two or more cells cannot be merge to one single span cell. * Bump main and legacyAdapter versions in versions.json --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Julia Roldi <87443959+juliaroldi@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jiuqing Song <jisong@microsoft.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

insert table content

16f39bf

JiuqingSong reviewed Jan 16, 2026

View reviewed changes

insert table

73cb1c0

juliaroldi changed the title ~~Insert table content~~ [Table Improvements] Insert table content Jan 26, 2026

juliaroldi and others added 4 commits February 2, 2026 18:11

table content

f7700bf

Merge branch 'master' into u/juliaroldi/insert-table-content

a01a4a3

fix build

afcca38

Merge branch 'master' into u/juliaroldi/insert-table-content

990768b

JiuqingSong reviewed Feb 4, 2026

View reviewed changes

juliaroldi added 2 commits February 5, 2026 14:12

fixes

894f703

Merge branch 'u/juliaroldi/insert-table-content' of https://github.co…

5fb3ab6

…m/microsoft/roosterjs into u/juliaroldi/insert-table-content

JiuqingSong reviewed Feb 5, 2026

View reviewed changes

juliaroldi added 2 commits February 5, 2026 18:54

fix build

d21c013

rename function

356e9cb

JiuqingSong approved these changes Feb 6, 2026

View reviewed changes

Merge branch 'master' into u/juliaroldi/insert-table-content

eae3b35

juliaroldi merged commit 0d1a49e into master Feb 6, 2026
7 checks passed

juliaroldi deleted the u/juliaroldi/insert-table-content branch February 6, 2026 18:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Table Improvements] Insert table content#3258

[Table Improvements] Insert table content#3258
juliaroldi merged 11 commits intomasterfrom
u/juliaroldi/insert-table-content

juliaroldi commented Jan 14, 2026

Uh oh!

JiuqingSong Jan 16, 2026

Uh oh!

juliaroldi Jan 20, 2026

Uh oh!

BryanValverdeU Jan 29, 2026

Uh oh!

JiuqingSong Jan 16, 2026

Uh oh!

JiuqingSong Jan 16, 2026

Uh oh!

JiuqingSong Feb 4, 2026

Uh oh!

JiuqingSong Feb 5, 2026

Uh oh!

JiuqingSong Feb 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

juliaroldi commented Jan 14, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants