🤖 User test baselines have changed#29933
Closed
typescript-bot wants to merge 1 commit intomicrosoft:masterfrom
Closed
🤖 User test baselines have changed#29933typescript-bot wants to merge 1 commit intomicrosoft:masterfrom
typescript-bot wants to merge 1 commit intomicrosoft:masterfrom
Conversation
typescript-bot
force-pushed
the
user-update-20190105
branch
from
0d2681a to
87318bf
Compare
sandersn
requested changes
Feb 15, 2019
Member
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
Everything looks good except the change to tsserverlibrary.d.ts. @weswigham can you take a look at that?
| excludedFiles: ReadonlyArray<NormalizedPath>; | ||
| private typeAcquisition; | ||
| updateGraph(): boolean; | ||
| getExcludedFiles(): readonly NormalizedPath[]; |
Member
There was a problem hiding this comment.
@weswigham I didn't expect to see this show up here.
Member
There was a problem hiding this comment.
Ahhhh, that's from the swap in gulp back to using the LKG for everything. The "remove jake" PR has the fix (accept the baseline, do a non-lkg validation build) already.
| node_modules/async/autoInject.js(168,6): error TS2695: Left side of comma operator is unused and has no side effects. | ||
| node_modules/async/cargo.js(62,12): error TS2304: Cannot find name 'AsyncFunction'. | ||
| node_modules/async/cargo.js(67,14): error TS2591: Cannot find name 'module'. Do you need to install type definitions for node? Try `npm i @types/node` and then add `node` to the types field in your tsconfig. | ||
| node_modules/async/cargo.js(67,14): error TS2749: 'module' refers to a value, but is being used as a type here. |
Member
There was a problem hiding this comment.
Seems like a regression from #29896, although I think maybe both errors should not happen in JS. Need to investigate.
Member
There was a problem hiding this comment.
Yeah, this is just horrible misunderstanding of the jsdoc module:QualifiedName syntax.
| Standard output: | ||
| node_modules/follow-redirects/index.js(105,10): error TS2339: Property 'emit' does not exist on type 'RedirectableRequest'. | ||
| node_modules/follow-redirects/index.js(106,10): error TS2339: Property 'abort' does not exist on type 'RedirectableRequest'. | ||
| node_modules/follow-redirects/index.js(173,10): error TS2339: Property 'emit' does not exist on type 'RedirectableRequest'. |
Member
There was a problem hiding this comment.
looks like a new version of follow-redirects
Member
There was a problem hiding this comment.
(Later) Yep. 1.7: https://www.npmjs.com/package/follow-redirects
| node_modules/chrome-devtools-frontend/front_end/animation/AnimationModel.js(553,11): error TS2339: Property 'AnimationModel' does not exist on type '{ new (effect?: AnimationEffect, timeline?: AnimationTimeline): Animation; prototype: Animation; }'. | ||
| node_modules/chrome-devtools-frontend/front_end/animation/AnimationModel.js(583,43): error TS2339: Property 'remove' does not exist on type 'Map<string, AnimationGroup>'. | ||
| node_modules/chrome-devtools-frontend/front_end/animation/AnimationModel.js(665,37): error TS2339: Property 'AnimationModel' does not exist on type '{ new (effect?: AnimationEffect, timeline?: AnimationTimeline): Animation; prototype: Animation; }'. | ||
| node_modules/chrome-devtools-frontend/front_end/animation/AnimationModel.js(691,24): error TS2304: Cannot find name 'Image'. |
| node_modules/chrome-devtools-frontend/front_end/Runtime.js(78,16): error TS7014: Function type, which lacks return-type annotation, implicitly has an 'any' return type. | ||
| node_modules/chrome-devtools-frontend/front_end/Runtime.js(95,28): error TS2339: Property 'response' does not exist on type 'EventTarget'. | ||
| node_modules/chrome-devtools-frontend/front_end/Runtime.js(147,37): error TS2339: Property '_importScriptPathPrefix' does not exist on type 'Window'. | ||
| node_modules/chrome-devtools-frontend/front_end/Runtime.js(158,21): error TS2345: Argument of type 'Promise<string>' is not assignable to parameter of type 'Promise<undefined>'. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review the diff and merge if no changes are unexpected.
You can view the build log here.
cc @weswigham @sandersn @RyanCavanaugh