Improve error message for using value as type#29896
Merged
RyanCavanaugh merged 3 commits intomicrosoft:masterfrom Feb 14, 2019
Merged
Improve error message for using value as type#29896RyanCavanaugh merged 3 commits intomicrosoft:masterfrom
RyanCavanaugh merged 3 commits intomicrosoft:masterfrom
Conversation
Member
|
Looks great. I think the edge cases are no more confusing than the prior version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #29778.
The new error message is in most casses an improvement over the old. There are a few corner casses where there are already other errors and the new message might not be helpful, but I would like an opinion on them
If this is deemed too confusing, I could check that the found symbol declaration is not a parent of the node being checked.
This one I am not sure how to revert back to the old error, ideally I would not report the new error message if the found symbol has a duplicate, but I have not found a wat to access this information in
resolveName.