This repository was archived by the owner on Jul 31, 2023. It is now read-only.
rems endpoint updates#38
Merged
Merged
Conversation
zacharyrobin
approved these changes
Aug 25, 2022
zacharyrobin
left a comment
There was a problem hiding this comment.
tested out each iteration I could think of and verified ETASU updates correctly. Looks good on my end.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
you should be able to submit the patient enrollment forms, prescriber enrollment form, and knowledge assessment form and the REMS endpoint should be able to adjust the status of the rems request dynamically instead of having everything stubbed out.
The endpoint changes break the REMS UI in dtr in the case of forms that do not create a new rems request case (basically everything that's not a patient enrollment form). Dtr is supposed to be all white with no data shown in these cases, updating that UI will be done in follow up work (REMS-232)
Best way to test this would be to connect to the h2 console at http://localhost:8090/h2-console (jdbc url: jdbc:h2:mem:myDb;DB_CLOSE_DELAY=-1, user: sa, pass: "") and watch the met requirements table to see how it populates as the forms are submitted. Restarting CRD will reinitialize the database to its starting position and remove any additional met requirements if that helps with testing.
There are also still some aspects that need to be cleaned up with the database (for example setting the drug - rems relationship and setting the completed resources for each MetReq) however these are not critical for the 0.6 demo and will be finished in a follow up ticket (REMS-233)