Skip to content

change api to use github REST api#268

Closed
sheimi wants to merge 3 commits into
magefile:masterfrom
cresta:master
Closed

change api to use github REST api#268
sheimi wants to merge 3 commits into
magefile:masterfrom
cresta:master

Conversation

@sheimi

@sheimi sheimi commented Jan 28, 2023

Copy link
Copy Markdown

No description provided.

@crazy-max

Copy link
Copy Markdown
Member

@sheimi I will switch to the Octokit client to see how it goes

@sheimi

sheimi commented Jan 28, 2023

Copy link
Copy Markdown
Author

Looks like release name is different. Octokit make sense. the api is rate limited without token.

@sheimi

sheimi commented Jan 28, 2023

Copy link
Copy Markdown
Author

but with Octokit, GITHUB_TOKEN is required. https://github.com/octokit/auth-action.js#createactionauth . Hope Github will revert their release soon.

@crazy-max

Copy link
Copy Markdown
Member

but with Octokit, GITHUB_TOKEN is required. https://github.com/octokit/auth-action.js#createactionauth . Hope Github will revert their release soon.

api.github.com is rate limited so we need a token anyway 😞 (can be automatically injected without changes in your workflow)

I'm addressing the changes in #269 but thanks for your contrib!

@sheimi

sheimi commented Jan 28, 2023

Copy link
Copy Markdown
Author

Thanks for the fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants