Pagination hotfix#3009
Conversation
Updates to issues templates
Remove pagination code
|
@marcellamaki Here's an interim report: <25 channels account is tested (20 channels) - the issue with the disappearing channels is no longer experienced and the system performance is stable with this amount of channels. UPDATE 1: Studio's performance with 58 channels seems stable. No channels disappear. We'll update about the case with 25-50 but I expect all will be fine there too. |
|
Thank you @metodimilevqa - this is very helpful! |
Codecov Report
@@ Coverage Diff @@
## master #3009 +/- ##
==========================================
- Coverage 85.73% 85.73% -0.01%
==========================================
Files 298 298
Lines 15876 15875 -1
==========================================
- Hits 13611 13610 -1
Misses 2265 2265
Continue to review full report at Codecov.
|
Summary
Description of the change(s) you made
This PR fixes #3005 which is an issue with channels briefly disappearing.
It also includes Sairina's updates to the Studio issue template.
Manual verification steps performed
For 3005:
Initial test
Does this introduce any tech-debt items?
Yes, this would revert pagination. As @micahscopes noted, this merits more discussion about whether or not there are backend considerations here, or if it is mainly a frontend UX/navigability issue.
Reviewer guidance
How can a reviewer test these changes?
Are there any risky areas that deserve extra testing?
@metodimilevqa - there has been some discussion on the dev side if reverting this pagination feature will cause performance issues. We will discuss more on Monday, so some additional testing with an eye on performance would be extremely informative. Would you be able to test this several times using accounts that have varying numbers of channels? For example, perhaps one account <25 channels, one with between 25 - 50 channels, and one with > 50 channels? Thank you for your help on this!
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)