Skip to content

Pagination hotfix#3009

Merged
bjester merged 7 commits into
masterfrom
hotfixes-pagination-2021-03-05
Mar 8, 2021
Merged

Pagination hotfix#3009
bjester merged 7 commits into
masterfrom
hotfixes-pagination-2021-03-05

Conversation

@marcellamaki
Copy link
Copy Markdown
Member

Summary

Description of the change(s) you made

This PR fixes #3005 which is an issue with channels briefly disappearing.
It also includes Sairina's updates to the Studio issue template.

Manual verification steps performed

For 3005:
Initial test

  1. Added a new channel
  2. Navigate back to channel page
  3. All channels continued to appear, with none disappearing

Does this introduce any tech-debt items?

Yes, this would revert pagination. As @micahscopes noted, this merits more discussion about whether or not there are backend considerations here, or if it is mainly a frontend UX/navigability issue.


Reviewer guidance

How can a reviewer test these changes?

  1. Add a new channel
  2. Navigate back to channel page
  3. All channels should continue to appear (none should disappear from the bottom)

Are there any risky areas that deserve extra testing?

@metodimilevqa - there has been some discussion on the dev side if reverting this pagination feature will cause performance issues. We will discuss more on Monday, so some additional testing with an eye on performance would be extremely informative. Would you be able to test this several times using accounts that have varying numbers of channels? For example, perhaps one account <25 channels, one with between 25 - 50 channels, and one with > 50 channels? Thank you for your help on this!

Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@marcellamaki marcellamaki requested review from bjester, micahscopes and rtibbles and removed request for micahscopes March 5, 2021 22:07
@metodimilevqa
Copy link
Copy Markdown

metodimilevqa commented Mar 8, 2021

@marcellamaki Here's an interim report: <25 channels account is tested (20 channels) - the issue with the disappearing channels is no longer experienced and the system performance is stable with this amount of channels.
We continue the tests with 25-50 and >50 channels and I'll update this comment as soon as we are ready.

UPDATE 1: Studio's performance with 58 channels seems stable. No channels disappear. We'll update about the case with 25-50 but I expect all will be fine there too.

@marcellamaki
Copy link
Copy Markdown
Member Author

Thank you @metodimilevqa - this is very helpful!

Copy link
Copy Markdown
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment!

bjester
bjester previously approved these changes Mar 8, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 8, 2021

Codecov Report

Merging #3009 (c3da0fd) into master (dee0396) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3009      +/-   ##
==========================================
- Coverage   85.73%   85.73%   -0.01%     
==========================================
  Files         298      298              
  Lines       15876    15875       -1     
==========================================
- Hits        13611    13610       -1     
  Misses       2265     2265              
Impacted Files Coverage Δ
...ontentcuration/contentcuration/viewsets/channel.py 79.68% <ø> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bce6c7c...77a37ba. Read the comment docs.

@bjester bjester merged commit 0fe6c3a into master Mar 8, 2021
@bjester bjester deleted the hotfixes-pagination-2021-03-05 branch April 26, 2021 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants