Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
🦋 Changeset detectedLatest commit: 7646f59 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Jul 10, 2025
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
cjbell
approved these changes
Jul 10, 2025
kylemcd
changed the title
Member
Author
kylemcd
changed the base branch from
kyle-kno-9102-add-expo-build-step-to-ci
to
graphite-base/637
kylemcd
force-pushed
the
kyle-kno-8889-knockexpopushnotificaitonprovider-assumes-all-notifications
branch
from
85c9612 to
7646f59
Compare
kylemcd
deleted the
kyle-kno-8889-knockexpopushnotificaitonprovider-assumes-all-notifications
branch
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #637 +/- ##
===========================================
+ Coverage 23.74% 61.56% +37.81%
===========================================
Files 180 175 -5
Lines 6775 6850 +75
Branches 212 774 +562
===========================================
+ Hits 1609 4217 +2608
+ Misses 5166 2607 -2559
- Partials 0 26 +26
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As reported in #589, the
KnockExpoPushNotificationProvidertries to process messages that don't come from knock which results in 404 errors. This PR adds a check toupdateKnockMessageStatusFromNotificationthat ensures that only messages which containknock_message_idare processed, the rest being ignored.