Skip to content

chore: remove react-native example app#629

Merged
kylemcd merged 2 commits intomainfrom
kyle-kno-9095-remove-react-native-example-app
Jul 10, 2025
Merged

chore: remove react-native example app#629
kylemcd merged 2 commits intomainfrom
kyle-kno-9095-remove-react-native-example-app

Conversation

@kylemcd
Copy link
Copy Markdown
Member

@kylemcd kylemcd commented Jul 9, 2025

Description

React Native docs recommend using expo instead of react-native directly. Also this example app doesn't even run properly anymore. So let's delete it.

@linear
Copy link
Copy Markdown

linear Bot commented Jul 9, 2025

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jul 9, 2025

⚠️ No Changeset found

Latest commit: 3d53315

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Jul 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
javascript-ms-teams-connect-example ⬜️ Ignored (Inspect) Visit Preview Jul 10, 2025 4:27pm
javascript-nextjs-example ⬜️ Ignored (Inspect) Visit Preview Jul 10, 2025 4:27pm
javascript-slack-connect-example ⬜️ Ignored (Inspect) Visit Preview Jul 10, 2025 4:27pm
javascript-slack-kit-example ⬜️ Ignored (Inspect) Visit Preview Jul 10, 2025 4:27pm

Copy link
Copy Markdown
Member Author

kylemcd commented Jul 9, 2025

@kylemcd kylemcd marked this pull request as ready for review July 9, 2025 18:39
@kylemcd kylemcd requested a review from a team as a code owner July 9, 2025 18:39
@kylemcd kylemcd requested review from cjbell, meryldakin and thomaswhyyou and removed request for a team July 9, 2025 18:39
@kylemcd kylemcd mentioned this pull request Jul 9, 2025
@kylemcd kylemcd requested a review from mattmikolay July 9, 2025 21:26
@mattmikolay
Copy link
Copy Markdown
Contributor

We might want to put in the effort to fix this React Native example app at some point. We created it specifically to demo using our React Native SDK without Expo. And we do link to it from our docs.

@cjbell — any thoughts here? Should we should just get rid of this example app considering it’s broken? Or should we try to fix it as part of ATC?

@kylemcd kylemcd force-pushed the kyle-kno-9091-update-expo-example-to-work-with-latest-version-of-expo branch from 43d87d8 to 8ec28ba Compare July 10, 2025 15:38
@kylemcd kylemcd force-pushed the kyle-kno-9095-remove-react-native-example-app branch from f8040c1 to 11d6527 Compare July 10, 2025 15:38
Copy link
Copy Markdown
Member Author

kylemcd commented Jul 10, 2025

Merge activity

  • Jul 10, 4:20 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jul 10, 4:23 PM UTC: Graphite rebased this pull request as part of a merge.
  • Jul 10, 4:26 PM UTC: @kylemcd merged this pull request with Graphite.

@kylemcd kylemcd changed the base branch from kyle-kno-9091-update-expo-example-to-work-with-latest-version-of-expo to graphite-base/629 July 10, 2025 16:21
@kylemcd kylemcd changed the base branch from graphite-base/629 to main July 10, 2025 16:21
@kylemcd kylemcd force-pushed the kyle-kno-9095-remove-react-native-example-app branch from 11d6527 to 3d53315 Compare July 10, 2025 16:22
@kylemcd kylemcd merged commit e32ce06 into main Jul 10, 2025
7 of 11 checks passed
@kylemcd kylemcd deleted the kyle-kno-9095-remove-react-native-example-app branch July 10, 2025 16:26
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.61%. Comparing base (164af54) to head (3d53315).
Report is 52 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #629       +/-   ##
===========================================
+ Coverage   23.74%   61.61%   +37.86%     
===========================================
  Files         180      175        -5     
  Lines        6775     6844       +69     
  Branches      212      774      +562     
===========================================
+ Hits         1609     4217     +2608     
+ Misses       5166     2601     -2565     
- Partials        0       26       +26     

see 102 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants