Update Inflater dynamic header reader to support partial reads#249
Merged
Conversation
Returning true here just puts us in an infinite loop, not sure what was supposed to happen? Fixes icsharpcode#229.
This reverts commit 2dcb656.
* Permits using ArraySegment instead of copying the source array * Formatting
* Uses Enumerable state machine * Skips two array copies by using ArraySegment * Throws usable exceptions when invalid values are being read
This reverts commit fb4ed40.
piksel
added
ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #233 got rid of the state machine for reading dynamic headers, this means that it may fail to read the header when using small buffers or with unlucky alignment.
This PR reintroduces a state machine that fully supports partial reading and continuing when more data is available.
It also handles invalid header data/state correctly and throws useful exceptions on bad data.
I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.