Fix infinite loop on bad literal data (Issue #229)#233
Merged
Conversation
Returning true here just puts us in an infinite loop, not sure what was supposed to happen? Fixes icsharpcode#229.
This reverts commit 2dcb656.
- No more gotos (!) - Easier to read - Handles bad table lengths correctly
piksel
added
zip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If no end symbol is reached before the memory in the output window runs out, it will just be flushed to the output and reset the window without progressing. This causes an infinite loop on bad Huffman data (32768 consecutive literals).
This is caused by allowing bad values into the table and this fix only prevents the infinite loop, not the real cause.
I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.