fix: resolve symlinks in launcher script for npm global install#6
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the binary build process to generate a Unix shell launcher that can locate the packaged lib/ directory correctly even when the executable is installed as an npm global symlink (common for npm i -g).
Changes:
- Update the generated Unix launcher to resolve symlinks (via
readlink -f/realpath) before computing the path tolib/hyperagent-launcher.cjs.
The shell launcher used ${0%/*} to find its lib/ directory, but when
npm installs globally it creates a symlink in the bin dir. ${0%/*}
resolves to the npm bin dir, not the package dir, causing:
Cannot find module '.../lib/hyperagent-launcher.cjs'
Use readlink -f / realpath to resolve symlinks before computing the
relative path to the lib directory.
Tested: symlink from /tmp/ → prints version correctly; old approach
confirmed to fail with MODULE_NOT_FOUND.
Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
simongdavies
force-pushed
the
fix-npm-launcher
branch
from
c24da67 to
30ff929
Compare
simongdavies
added a commit
to simongdavies/hyperagent
that referenced
this pull request
May 14, 2026
- Fix hyperlight-dev#2: Use MCP_SETUP_COMMANDS lookup for correct CLI setup hints (was generating 'setup-rti-mcp' instead of '--mcp-setup-fabric-rti') - Fix hyperlight-dev#3: Show unconfigured status when mcpManager is null - Fix hyperlight-dev#4: Update test assertion to match corrected setup command - Fix hyperlight-dev#5: Add highlight.js ^10.7.3 as explicit dependency (was transitive) - Fix hyperlight-dev#6: Validate Fabric RTI options — reject missing values & unknown flags - Fix hyperlight-dev#7: Set HYPERAGENT_VERBOSE=1 from cli.verbose flag - Fix hyperlight-dev#8: Update skill count from 9 to 10 in docs/SKILLS.md - Fix hyperlight-dev#9: Use stderr 'ignore' instead of 'pipe' to avoid back-pressure - Fix hyperlight-dev#10: Add CLI parser test for --mcp-setup-fabric-rti flag Comment hyperlight-dev#1 (hljs types) is invalid — typecheck passes with /// <reference>. Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
simongdavies
added a commit
that referenced
this pull request
May 14, 2026
- /markdown toggle: set sessionNeedsRebuild so system prompt updates (#1) - CLI help: document --[no-]markdown, --md/--no-md aliases, HYPERAGENT_MARKDOWN (#6) - Streamed output: gate renderMarkdown on looksLikeMarkdown consistently (#7) - markdown-renderer: use local Marked instance instead of global setOptions (#9) - looksLikeMarkdown: remove over-eager bold and unordered-list patterns (#10) - unescape: verified valid marked-terminal option (comment was wrong) (#8) - linkifyFiles order: verified safe — [[file:]] not a markdown token (#16) Verified: diff matches this message. 40 test files, 2350 tests pass. Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
simongdavies
added a commit
that referenced
this pull request
May 14, 2026
* feat: KQL expert skill with requires-mcp, trigger cleanup, syntax highlighting - Add kql-expert skill (SKILL.md) with 35 triggers, requires-mcp: fabric-rti-mcp - Add requires-mcp frontmatter support in skill-loader + approach-resolver - Add MCP enrichment wiring in agent index.ts - Add --mcp setup-fabric-rti CLI command - Clean generic triggers across 7 skills to prevent false matches - Add hljs-kql.ts grammar (derived from @kusto/monaco-kusto MIT) - Register KQL/Kusto syntax highlighting in markdown-renderer via createRequire - Add intent-matcher regression tests (27 tests: 22 positive + 5 guards) - Add skill-loader tests (8 tests) and approach-resolver MCP tests (8 tests) All 2396 tests pass. Typecheck clean. Fmt clean. Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com> * fix: gate diagnostic output behind --verbose/--debug flags - Rust: gate [hyperlight-analysis] eprintln! behind HYPERAGENT_VERBOSE/DEBUG env vars - MCP: gate [mcp] Connected/Auth success messages behind isVerbose() - MCP: pipe subprocess stderr when not verbose to suppress Python INFO logs - KQL skill: remove azuremcpserver reference, add anti-pattern to use fabric-rti-mcp only Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com> * docs: update skill tables and add requires-mcp documentation - Add all 9 skills to tables in docs/SKILLS.md, README.md, skills/CLAUDE.md, and .github/instructions/skills.instructions.md (was missing kql-expert, xlsx-expert, mcp-services in various files) - Document requires-mcp frontmatter field in docs/SKILLS.md - Add requires-mcp to YAML examples in instruction files - Alphabetise skill tables for consistency Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com> * fix: address PR #137 review feedback (9 issues) - Fix #2: Use MCP_SETUP_COMMANDS lookup for correct CLI setup hints (was generating 'setup-rti-mcp' instead of '--mcp-setup-fabric-rti') - Fix #3: Show unconfigured status when mcpManager is null - Fix #4: Update test assertion to match corrected setup command - Fix #5: Add highlight.js ^10.7.3 as explicit dependency (was transitive) - Fix #6: Validate Fabric RTI options — reject missing values & unknown flags - Fix #7: Set HYPERAGENT_VERBOSE=1 from cli.verbose flag - Fix #8: Update skill count from 9 to 10 in docs/SKILLS.md - Fix #9: Use stderr 'ignore' instead of 'pipe' to avoid back-pressure - Fix #10: Add CLI parser test for --mcp-setup-fabric-rti flag Comment #1 (hljs types) is invalid — typecheck passes with /// <reference>. Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com> --------- Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shell launcher used ${0%/} to find its lib/ directory, but when npm installs globally it creates a symlink in the bin dir. ${0%/} resolves to the npm bin dir, not the package dir, causing:
Cannot find module '.../lib/hyperagent-launcher.cjs'
Use readlink -f / realpath to resolve symlinks before computing the relative path to the lib directory.
Tested: symlink from /tmp/ → prints version correctly; old approach confirmed to fail with MODULE_NOT_FOUND.