Feat kql expert

[simongdavies]

This pull request introduces support for skills that require connection to external MCP (Modular Control Plane) servers, such as Fabric RTI for Kusto/KQL queries. It updates the skill documentation and metadata formats to declare MCP server dependencies, extends the approach resolver to collect and report MCP server requirements and statuses, and enhances CLI tooling for MCP server setup. The changes also expand and clarify the available skills and their triggers across documentation and skill files.

Skill system enhancements:

• Added requires-mcp field to skill metadata (in .md and SKILL.md files) to declare MCP server dependencies for skills. This allows the agent to check and report required external server connections for a skill to function.
• Updated skill documentation (docs/SKILLS.md, README.md, and skill files) to explain MCP server dependencies, enumerate new and existing skills, and clarify their descriptions and triggers.

Approach resolver and runtime guidance:

• Extended the MaterialisedGuidance interface and approach resolver logic to collect required MCP servers (requiredMcp) and their runtime statuses (mcpStatus). This enables the agent to inform the LLM and user about MCP connection requirements and current connection state.
• Improved the guidance formatting to display MCP server connection status, including setup instructions, connection state, tool count, and error reporting.

CLI tooling:

• Added a new CLI command --mcp-setup-fabric-rti for configuring the Fabric RTI (Kusto/KQL) MCP server, supporting easier setup for skills that require this backend.

Skill trigger and pattern improvements:

• Refined and expanded triggers and patterns for several skills (api-explorer, data-processor, pdf-expert, report-builder, research-synthesiser, web-scraper, mcp-services) to improve skill matching and clarify their capabilities.

[Copilot]

Pull request overview

This PR adds MCP-aware skill support, centered on a new KQL/Kusto expert skill that uses a Fabric RTI MCP server, and updates guidance, CLI setup, rendering, and tests around that workflow.

Changes:

• Adds requires-mcp skill metadata and propagates MCP requirements into approach guidance.
• Adds Fabric RTI setup plumbing and KQL syntax highlighting.
• Expands/refines skill definitions, documentation, and intent/loader/resolver tests.

Reviewed changes

Copilot reviewed 24 out of 24 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
src/agent/skill-loader.ts	Parses requires-mcp metadata into loaded skills.
src/agent/approach-resolver.ts	Adds required MCP/status fields and MCP guidance formatting.
src/agent/index.ts	Enriches auto-generated guidance with runtime MCP server status.
src/agent/cli-parser.ts	Adds --mcp-setup-fabric-rti CLI parsing.
src/agent/mcp/setup-commands.ts	Adds Fabric RTI MCP setup command.
src/agent/mcp/client-manager.ts	Adjusts MCP logging/stderr verbosity handling.
src/agent/markdown-renderer.ts	Registers KQL highlighting for terminal markdown.
src/agent/hljs-kql.ts	Adds highlight.js grammar for KQL/Kusto.
src/code-validator/guest/host/src/runtime.rs	Gates runtime lifecycle logs behind verbose/debug env vars.
skills/kql-expert/SKILL.md	Adds new KQL expert skill requiring Fabric RTI MCP.
skills/api-explorer/SKILL.md	Refines API triggers.
skills/data-processor/SKILL.md	Refines data-processing triggers.
skills/mcp-services/SKILL.md	Refines MCP service triggers.
skills/pdf-expert/SKILL.md	Refines PDF triggers.
skills/report-builder/SKILL.md	Refines report triggers.
skills/research-synthesiser/SKILL.md	Refines research triggers.
skills/web-scraper/SKILL.md	Refines scraping triggers.
skills/CLAUDE.md	Updates skill documentation and metadata template.
.github/instructions/skills.instructions.md	Updates skill instruction template/list.
docs/SKILLS.md	Documents MCP dependencies and updated skills.
README.md	Adds KQL expert to the skills overview.
tests/skill-loader.test.ts	Adds skill loader coverage, including requires-mcp.
tests/approach-resolver.test.ts	Adds MCP requirement/status formatting tests.
tests/intent-matcher.test.ts	Adds real skill intent matching regression tests.

Comments suppressed due to low confidence (1)

src/agent/hljs-kql.ts:350

• Because the shorter alternatives (create, alter, set, etc.) appear before their hyphenated forms and \b matches before -, commands such as .create-or-alter and .set-or-append will be highlighted only as .create/.set. Put longer hyphenated commands first or use a boundary that does not split on hyphens.

  const COMMAND: Mode = {
    className: "meta",
    begin:
      /\.(show|create|alter|drop|set|append|delete|rename|move|replace|ingest|export|create-or-alter|alter-merge|create-merge|set-or-append|set-or-replace|drop-pretend)\b/,
  };