Add sobel in hexagon benchmarks app for CMake builds#8127
Merged
steven-johnson merged 3 commits intohalide:mainfrom Mar 6, 2024
Merged
Add sobel in hexagon benchmarks app for CMake builds#8127steven-johnson merged 3 commits intohalide:mainfrom
steven-johnson merged 3 commits intohalide:mainfrom
Conversation
Resolved compilation errors caused by the eliminate interleave pass, which changed the instruction from halide.hexagon.pack_satub.vuh to halide.hexagon.trunc_satub.vuh. The latter is only available in v65 or later. This commit ensures compatibility with v65 and later versions.
Contributor
|
|
Contributor
Author
Fixed test failure due to my silly mistake in the patch. |
prasmish
force-pushed
the
feature/sobel-hexagon-benchmarks
branch
from
2c90341 to
587a615
Compare
steven-johnson
approved these changes
Mar 6, 2024
Contributor
steven-johnson
left a comment
steven-johnson
left a comment
There was a problem hiding this comment.
LGTM pending greeen
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding sobel test back which was removed in PR #8069.
Previously,
sobeltest was not building correctly with the targethost-hvx. The compilation errors were caused by the eliminate interleave pass, which changed the instruction fromhalide.hexagon.pack_satub.vuhtohalide.hexagon.trunc_satub.vuh. The latter instruction is only available inv65or later andhost-hvxby default isv62. This commit ensures compatibility with v65 and later versions.