Add hexagon_benchmarks app for CMake builds#8069
Merged
steven-johnson merged 3 commits intohalide:mainfrom Feb 7, 2024
Merged
Conversation
steven-johnson
approved these changes
Feb 6, 2024
Contributor
steven-johnson
left a comment
There was a problem hiding this comment.
Thanks so much for this fix! LGTM pending green.
Contributor
|
Contributor
Author
|
Earlier, I was building Halide with Clang, which led to a minor issue here. I’ve now eliminated an unneeded flag (-lc++abi) and now it should build smoothly. |
Contributor
|
Failures are unrelated |
ardier
pushed a commit
to ardier/Halide-mutation
that referenced
this pull request
Mar 3, 2024
* Add hexagon_benchmarks app for CMake builds * Removed unnecessary -lc++abi flag from GCC build
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue raised in #5374 regarding the lack of CMake support for hexagon_benchmark. Specifically, it introduces CMake build support for the
hexagon_benchmarkapp which was previously missing.During the process of adding this support, I observed that the
sobeltest was not building correctly with the targethost-hvx. To keep this PR focused and manageable, thesobeltest has been temporarily removed from this CMake script. A separate PR will be raised to rectify this issue and reintroduce thesobeltest. (in #8127)Fixes #8733