Skip to content

Adapt r-ci to altdoc needs#443

Closed
eddelbuettel wants to merge 1 commit into
grantmcdermott:altdoc_configfrom
eddelbuettel:altdoc_config
Closed

Adapt r-ci to altdoc needs#443
eddelbuettel wants to merge 1 commit into
grantmcdermott:altdoc_configfrom
eddelbuettel:altdoc_config

Conversation

@eddelbuettel
Copy link
Copy Markdown

Amused myself with a fork only to fall into the trap of not having actions run in the fork. Not sure why. Oh well.

@grantmcdermott
Copy link
Copy Markdown
Owner

Ugh, annoying. Copied your code across to my original PR so let's hope that runs. Thanks Dirk.

@eddelbuettel
Copy link
Copy Markdown
Author

Merging would have done that, no?

image

@grantmcdermott
Copy link
Copy Markdown
Owner

True. Sorry, was doing quickly from my phone.

@eddelbuettel
Copy link
Copy Markdown
Author

It's sadly not the first time if memory serves. You tagged me, in response I gave you a PR, which you closed only to actually copy the code sans attribution. Almost like a perfect satire about how not to deal with contributors. Anyway, spilled milk now.

@grantmcdermott
Copy link
Copy Markdown
Owner

? I read your comment quickly and misinterpreted it as running into the same problem I originally did in #439. And I must add: quite uncool to suggest (reoccurring!) malice here. Fwiw I certainly plan to tag and thank you when I update the NEWS, just as I have before.

@eddelbuettel
Copy link
Copy Markdown
Author

I did not mean imply intent. I only noted that the outcome was suboptimal. Anyway, you have your requested fix now and the caravan moves on...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants