Move altdoc to config#439
Conversation
|
Hmmm, this somehow seems have removed the altdoc CI workflow completely :-/ Edit: no it's just missing b/c of an invalid structure: https://github.com/grantmcdermott/tinyplot/actions/runs/16172287106 |
|
@eddelbuettel Do you know if there's a way to include a For context, this is what I was trying to run (in turn, based on @etiennebacher's equivalent r-lib/actions workflow here). This fails because the "with" statement needs to be paired with a defined "use" action statement rather than a "run" shell script. tinyplot/.github/workflows/altdoc.yaml Lines 35 to 39 in a8ac33d |
|
I am confused. I have no idea what you are trying to do / what gave you the idea this would be supported. Likewise when And so on -- there are other examples doing an extra step as needed. You could also wrap that in an action with arguments, and if you think it adds value, have random new fields from At the end of the day a GHA file is just three shellscripts hiding inside a yaml trenchcoat. |
| run: ./run.sh install_all | ||
| with: | ||
| needs: website | ||
| cache: "always" |
There was a problem hiding this comment.
You need the logical equivalent of the declaration of line 55 below added here, potentially in two (OS-dependent) blocks depending on which OS you want to run here. If it is 'merely' an Linux-only documentation build step you do not need to condition and can just list what is needed as arguments to apt, or to install.r (wrapping install.packages()) if you want it to be R. Similarly, installGithub.r fetches from where you think it does etc.
|
So I think this may work: - name: Dependencies
run: |
# default packages
./run.sh install_all
# altdoc from GH
./run.sh install_github etiennebacher/altdoc
# plus future.apply
./run.sh install_r future.apply[ Untested though. ] PS Depending on what |
|
Thanks Dirk, will test after work. (Also: had a good chuckle at "GHA file is just three shellscripts hiding inside a yaml trenchcoat".) |
|
The above should work for yoy. It effectively 'hides' the config in the yaml file. You may like or dislike that. But if you want to configure this in the DESCRIPTION file then you have to way to extract (maybe Or ... you could just treat GHA-driven altdoc generation as a perfectly separate step CRAN does not need to know about and cleanly shove it into the yaml file. Keeps concerns separated, and will never affect your CRAN upload. |
Ya, this is what I'm ultimately aiming for. One less suggests on CRAN and I can remove the (presently annoying) juggle to pull in the dev version. |
|
Tried to help you our with a test via a quick fork-and-pr (in #443) alas no action was triggered. |
|
I integrated your changes directly in this PR and... huzzah, that seems to have done it. Thanks @eddelbuettel! |
|
Ugh, spoke to soon. Failed on main branch now due to GitHub API rate throttling https://github.com/grantmcdermott/tinyplot/actions/runs/16281104006 I'm going to have have ask Etienne or Vincent to make the dev version of this package available on R-universe or easier target. |
Testing the setup suggested by @etiennebacher here: etiennebacher/altdoc#322 (comment)
This is so we can use the dev version of altdoc, but avoid having to comment things out for CRAN submission.
(I'm not sure that it will work given our reliance on Dirk's r-ci script, but let's see what CI throws up.)