assign pt.lwd for type "p" in legend#320
Merged
grantmcdermott merged 2 commits intograntmcdermott:mainfrom Feb 18, 2025
Merged
Conversation
Signed-off-by: Kyle Scott <kms309@miami.edu>
Owner
|
Thanks @kscott-1, good catch! Do you mind adding/committing a short I'll merge once that's done. |
Contributor
Author
|
Thanks @grantmcdermott, let me know if that works for you. Glad I could contribute to a great project. |
Collaborator
|
This is very cool. Thanks for the bug fix! |
Owner
|
Thanks! |
Owner
|
(Your PR also reminded me of a separate issue related to handing of character variables and default types, which I'll address separately.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #319. Looking at the issue I posted earlier, it appears that the jitter plot is internally referenced as "p" type. While my knowledge of this codebase is next to nothing, I don't believe there should be unintended consequences of this change because "p" should only include points. The changes allow for the legend to pick up the
lwdargument in the case that thepchused during plotting can be impacted by that value. Happy to hear more if I have misunderstood this :)