chore: update default versions to match generated code#8581
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
jskeet
commented
Jun 11, 2026
| skip_generate: true | ||
| nodejs: | ||
| default_version: v1beta | ||
| default_version: v1 |
Contributor
Author
There was a problem hiding this comment.
This is wrong and I'm confused... looking again.
Contributor
Author
There was a problem hiding this comment.
(Basically workstations was already okay, but generated before we specified default versions. Will revert this bit.)
This addresses situations where .repo-metadata.json and index.ts effectively disagree on the default API version for a package. The fix favors the version in index.ts, for the sake of compatibility. Once this is merged, googleapis#8556, googleapis#8571 and googleapis#8480 should be regenerated. Fixes googleapis/librarian#6382
jskeet
force-pushed
the
fix-default-versions
branch
from
June 11, 2026 11:48
bbe0b20 to
30beb8b
Compare
suztomo
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses situations where .repo-metadata.json and index.ts effectively disagree on the default API version for a package. The fix favors the version in index.ts, for the sake of compatibility.
Once this is merged, #8556, #8571 and #8480 should be regenerated.
Fixes googleapis/librarian#6382