chore: migrate google-cloud-apiregistry to librarian#8556
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request enables code generation for the Cloud API Registry API by removing the skip_generate flag, updating the repository metadata, and switching the default client version to v1beta in index.ts. However, manual edits to the generated TypeScript client files and .repo-metadata.json should be avoided, as these changes must be made upstream in the generator.
| const CloudApiRegistryClient = v1beta.CloudApiRegistryClient; | ||
| type CloudApiRegistryClient = v1beta.CloudApiRegistryClient; |
There was a problem hiding this comment.
Do not manually edit generated TypeScript client files. Any changes or updates, such as reverting the default client version, must be made upstream in the generator.
References
- Do not manually edit generated TypeScript client files. Any changes or updates must be made upstream in the generator.
| "api_id": "cloudapiregistry.googleapis.com", | ||
| "api_shortname": "cloudapiregistry", | ||
| "client_documentation": "https://cloud.google.com/nodejs/docs/reference/apiregistry/latest", | ||
| "default_version": "v1beta", |
There was a problem hiding this comment.
Do not manually edit generated client configuration JSON files. Any changes or updates to .repo-metadata.json must be made upstream in the generator.
References
- Do not manually edit generated client configuration JSON files. Any changes or updates must be made upstream in the generator.
This addresses situations where .repo-metadata.json and index.ts effectively disagree on the default API version for a package. The fix favors the version in index.ts, for the sake of compatibility. Once this is merged, googleapis#8556, googleapis#8571 and googleapis#8480 should be regenerated. Fixes googleapis/librarian#6382
This addresses situations where .repo-metadata.json and index.ts effectively disagree on the default API version for a package. The fix favors the version in index.ts, for the sake of compatibility. Once this is merged, #8556, #8571 and #8480 should be regenerated. Fixes googleapis/librarian#6382
c877f17 to
c95e983
Compare
| "api_id": "cloudapiregistry.googleapis.com", | ||
| "api_shortname": "cloudapiregistry", | ||
| "client_documentation": "https://cloud.google.com/nodejs/docs/reference/apiregistry/latest", | ||
| "default_version": "v1", |
There was a problem hiding this comment.
Note that this is different to before, to match index.ts - basically this file was stale.
2 participants
No description provided.